https://bugs.dragonflybsd.org/https://bugs.dragonflybsd.org/favicon.ico?16293952082009-02-04T19:44:08ZDragonFlyBSD bugtrackerDragonFlyBSD - Bug #1267: Off by one bug in pci_intrcfghttps://bugs.dragonflybsd.org/issues/1267?journal_id=60932009-02-04T19:44:08Zcorecode
<ul></ul><p>Sure, I don't think you have to ask for permission. If you think the fix <br />needs to go in, it needs to go in :)</p>
<p>Is that a source of interrupt routing problems? Do you know when this bug <br />would happen and which effects it would have?</p>
<p>cheers<br /> simon</p> DragonFlyBSD - Bug #1267: Off by one bug in pci_intrcfghttps://bugs.dragonflybsd.org/issues/1267?journal_id=60942009-02-04T20:13:13Zsepherosa
<ul></ul><p>On Wed, Feb 4, 2009 at 7:43 PM, Simon 'corecode' Schubert<br /><<a class="email" href="mailto:corecode@fs.ei.tum.de">corecode@fs.ei.tum.de</a>> wrote:</p>
<blockquote>
<p>Sepherosa Ziehau wrote:</p>
<blockquote>
<p>Hi all,</p>
<p>I want following patch in 2.2 release (i.e. I need the permission to<br />push it to master):</p>
<p><a class="external" href="http://leaf.dragonflybsd.org/~sephe/0001-pci-intr-config-Fix-an-off-by-one-bug.patch">http://leaf.dragonflybsd.org/~sephe/0001-pci-intr-config-Fix-an-off-by-one-bug.patch</a></p>
<p>Please review it.</p>
</blockquote>
<p>Sure, I don't think you have to ask for permission. If you think the fix<br />needs to go in, it needs to go in :)</p>
<p>Is that a source of interrupt routing problems? Do you know when this bug<br />would happen and which effects it would have?</p>
</blockquote>
<p>Can't say it will be root cause, however, it could cause potential problems.</p>
<p>Best Regards,<br />sephe</p> DragonFlyBSD - Bug #1267: Off by one bug in pci_intrcfghttps://bugs.dragonflybsd.org/issues/1267?journal_id=60992009-02-05T12:20:29Zdillon
<ul></ul><p>I don't even understand what that loop is doing :-) matchpin is<br /> supposed to start at 1?</p>
<pre><code>-Matt</code></pre> DragonFlyBSD - Bug #1267: Off by one bug in pci_intrcfghttps://bugs.dragonflybsd.org/issues/1267?journal_id=61002009-02-05T13:58:46Zsepherosa
<ul></ul><p>On Thu, Feb 5, 2009 at 12:18 PM, Matthew Dillon<br /><<a class="email" href="mailto:dillon@apollo.backplane.com">dillon@apollo.backplane.com</a>> wrote:</p>
<blockquote>
<p>I don't even understand what that loop is doing :-) matchpin is</p>
</blockquote>
<p>It tries to find the device using the same pin and has been "correctly" routed.</p>
<p>Yep, it starts from 1.</p>
<p>Best Regards,<br />sephe</p> DragonFlyBSD - Bug #1267: Off by one bug in pci_intrcfghttps://bugs.dragonflybsd.org/issues/1267?journal_id=61012009-02-05T18:59:50Zsepherosa
<ul></ul><p>OK to "push"?</p>
<p>Here is another trivial fix:<br /><a class="external" href="http://leaf.dragonflybsd.org/~sephe/0001-pci-intr-config-j-is-the-pin-index-we-want-to-ski.patch">http://leaf.dragonflybsd.org/~sephe/0001-pci-intr-config-j-is-the-pin-index-we-want-to-ski.patch</a></p>
<p>Please review it. I want to push the above patch too.</p>
<p>Best Regards,<br />sephe</p> DragonFlyBSD - Bug #1267: Off by one bug in pci_intrcfghttps://bugs.dragonflybsd.org/issues/1267?journal_id=61042009-02-06T02:16:52Zdillon
<ul></ul><p>:> Yep, it starts from 1.<br />:><br />:<br />:OK to "push"?<br />:<br />:Here is another trivial fix:<br />:http://leaf.dragonflybsd.org/~sephe/0001-pci-intr-config-j-is-the-pin-index-we-want-to-ski.patch<br />:<br />:Please review it. I want to push the above patch too.<br />:<br />:Best Regards,<br />:sephe<br />:<br />:-- <br />:Live Free or Die</p>
<pre><code>Yah, push'm both.</code></pre>
<pre><code>-Matt<br /> Matthew Dillon <br /> &lt;<a class="email" href="mailto:dillon@backplane.com">dillon@backplane.com</a>&gt;</code></pre> DragonFlyBSD - Bug #1267: Off by one bug in pci_intrcfghttps://bugs.dragonflybsd.org/issues/1267?journal_id=61462009-02-10T21:31:08Zcorecode
<ul></ul><p>committed</p>