Project

General

Profile

Bug #1311

Assertion on spin_unlock_wr_quick

Added by ahuete.devel almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%


Description

Hi all,

In spin_unlock_wr_quick() function, gd->gd_spinlocks_wr is always
decreased, even when its value is equal to 0. This shouldn't happen, and
if it happens then something may be wrong. In the patch below, I've
added a KKASSERT() before the decreasing as recommended by corecode.

http://gitweb.dragonflybsd.org/~tuxillo/dragonfly.git/commitdiff/721b254210a115e6c53b1d842cc560587eff3ae5

Regards,
Antonio Huete

History

#1 Updated by alexh over 7 years ago

I think this should be commited; it doesn't hurt and might avoid errors going by
unnoticed related to decreasing the spinlock count further than allowed.

#2 Updated by dillon over 7 years ago

:
:Alex Hornung <> added the comment:
:
:I think this should be commited; it doesn't hurt and might avoid errors goi=
:ng by=20
:unnoticed related to decreasing the spinlock count further than allowed.
:

Yah, I'll commit it. Good catch.

-Matt
Matthew Dillon
<>

#3 Updated by aoiko over 7 years ago

committed

Also available in: Atom PDF