https://bugs.dragonflybsd.org/https://bugs.dragonflybsd.org/favicon.ico?16293952082009-04-15T03:56:31ZDragonFlyBSD bugtrackerDragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=64032009-04-15T03:56:31Zswildner
<ul></ul><p>Does anything show in dmesg when running with your patch?</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=64872009-04-25T12:43:32Zbmk
<ul></ul><p>dmesg shows these extra lines when device plugged in:</p>
<p>umass0: <br /><\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^?\M^? <br />HUAWEI Mobile, class 0/0, rev 1.10/0.00, addr 2> on uhub1<br />cd1 at umass-sim0 bus 0 target 0 lun 0<br />cd1: <HUAWEI Mass Storage 2.31> Removable CD-ROM SCSI-2 device<br />cd1: 1.000MB/s transfers<br />cd1: Attempt to query device size failed: NOT READY, Medium not present</p>
<p>NOTE_1: dmesg is the same with or without my patch.<br />NOTE_2: I think the "Medium not present" is the empty MicroSD slot</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=64882009-04-25T12:45:34Zbmk
<ul></ul><p>Also, if anyone wants SSH root access to my box with E169 attached, <br />please let me know on this bug thread.</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=65342009-05-06T14:06:44Zalexh
<ul></ul><p>I've been looking a bit into the issue and made a few changes; the diff is<br />attached. Can you try and see if it helps?</p>
<p>PS: There might be a typo somewhere that doesn't allow to compile; haven't tried<br />it myself, but if so it should be trivial to fix.</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=65542009-05-09T08:30:24Zbmk
<ul></ul><p>Thanks Alex!!! Your patch works perfectly.</p>
<p>I am now surfing the net with E169 using pppd via /dev/ucom0.</p>
<p>Please submit/commit this.</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=65562009-05-09T23:11:18Zalexh
<ul></ul><p>Thanks for testing it.</p>
<p>I will clean it up a bit and then post it in my git repo. Don't commit it just <br />yet.</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=65582009-05-10T01:52:46Zalexh
<ul></ul><p>Ok, I've rewritten my fix to be a bit cleaner.<br />Here it is: <br /><a class="external" href="http://gitweb.dragonflybsd.org/~alexh/dragonfly.git/commit/e39cf0de1bdc15127d00a">http://gitweb.dragonflybsd.org/~alexh/dragonfly.git/commit/e39cf0de1bdc15127d00a</a><br />87fc6daa6b7dd8d3725</p>
<p>bmk, if you can give it a try, I'd be thankful; although it pretty much is the <br />same, just done differently.</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=66022009-05-12T19:37:26Zbmk
<ul></ul><p>Hi Alex, version 2 of you patch is not building:</p>
===> dev/usbmisc/ugensa<br />cc -O -pipe -D_KERNEL -Wall -Wredundant-decls -Wnested-externs <br />-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline <br />-Wcast-qual -Werror-implicit-function-declaration -std=c99 <br />-DKLD_MODULE -nostdinc -I. -I@ -I/usr/src/sys/compile/GENERIC_p2 <br />-I/usr/src/sys/compile/GENERIC_p2/include -I/usr/include -include <br />/usr/src/sys/compile/GENERIC_p2/opt_global.h -g -finline-limit=8000 <br />--param inline-unit-growth=100 --param large-function-growth=1000 <br />-fno-common -ffreestanding -mpreferred-stack-boundary=2 <br />-fno-stack-protector -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 <br />-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes <br />-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual <br />-Werror-implicit-function-declaration -std=c99 -c <br />/usr/src/sys/dev/usbmisc/ugensa/ugensa.c<br />/usr/src/sys/dev/usbmisc/ugensa/ugensa.c: In function 'ugensa_match':<br />/usr/src/sys/dev/usbmisc/ugensa/ugensa.c:186: error: expected ')' before <br />'{' token<br />/usr/src/sys/dev/usbmisc/ugensa/ugensa.c:202: error: expected expression <br />before '}' token<br />/usr/src/sys/dev/usbmisc/ugensa/ugensa.c:172: warning: unused variable 'id'
<ul>
<li>Error code 1</li>
</ul>
Stop in /usr/src/sys/dev/usbmisc/ugensa.
<ul>
<li>Error code 1</li>
</ul>
Stop in /usr/src/sys/dev/usbmisc.
<ul>
<li>Error code 1</li>
</ul>
Stop in /usr/src/sys/dev.
<ul>
<li>Error code 1</li>
</ul>
Stop in /usr/src/sys.
<ul>
<li>Error code 1</li>
</ul>
<p>Stop in /usr/src/sys/compile/GENERIC_p2.
#</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=66032009-05-12T19:46:43Zalexh
<ul></ul><p>ah, I see, small typo. Can you please try compiling with the following change <br />while I update my git repo?<br />change: if ((uaa->vendor == 0x12d1) {<br />to: if (uaa->vendor == 0x12d1) {</p>
<p>Thank you very much for testing it!</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=66042009-05-12T19:47:16Zbmk
<ul></ul><p>Woops, not sure why but I lost the subject on my bug thread. Just <br />putting the subject back...</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=66052009-05-12T20:25:12Zbmk
<ul></ul><p>Hi Alex,</p>
<p>I fixed the typo & it builds & works fine now.</p>
<p>Thanks...</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=66062009-05-12T20:29:37Zalexh
<ul></ul><p>Thanks for testing, I'll be fixing the typo in my repository in a while so it can <br />get commited.</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=66082009-05-12T20:46:23Zalexh
<ul></ul><p>Ok, I've fixed the typo in the repository, it can be found here: <br /><a class="external" href="http://gitweb.dragonflybsd.org/~alexh/dragonfly.git/commit/a1dd727dadf2e15512ff1">http://gitweb.dragonflybsd.org/~alexh/dragonfly.git/commit/a1dd727dadf2e15512ff1</a><br />2f0b4ad23d1b365d37c</p>
<p>As Brendan has already tested this successfully, I think it is ready.</p> DragonFlyBSD - Bug #1324: [PATCH] ugensa.c: better handling of Huawei Modemshttps://bugs.dragonflybsd.org/issues/1324?journal_id=67022009-05-31T17:16:48Zswildner
<ul></ul><p>Committed -> 7ffe1f6754372419182d1b1ab761af18a6d28090</p>