Bug #1346

[PATCH]

Added by alexh about 5 years ago. Updated about 5 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:alexh% Done:

0%

Category:-
Target version:-

Description

1) remove uses of __label__, which is not supported by llvm/clang and is not
needed for either gcc or llvm/clang.

2) remove uses of register type var __asm("ecx") and other variable
register-binding as it is not supported by llvm/clang and is superfluous. By
specifying that the variable content should go into ecx in the clobber list, the
current use is not needed.

3) add an ugly hack, conditionalized on __clang__, to allow correct
compilation of atomic_intr_cond_try(). This hack should be removed once
http://llvm.org/bugs/show_bug.cgi?id=3812 is solved. It is conditionalized on
__clang__ define because it is not a valid syntax for gcc.

Patch is at:
http://gitweb.dragonflybsd.org/~alexh/dragonfly.git/commit/6e6c8028465bf25a6e9f5685b57a3fee79f77382

History

#1 Updated by dillon about 5 years ago

:New submission from Alex Hornung <>:
:
:1) remove uses of __label__, which is not supported by llvm/clang and is no=
:t
:needed for either gcc or llvm/clang.
:
:2) remove uses of register type var __asm("ecx") and other variable
:register-binding as it is not supported by llvm/clang and is superfluous. B=
:y
:specifying that the variable content should go into ecx in the clobber list=
:, the
:current use is not needed.
:
:3) add an ugly hack, conditionalized on __clang__, to allow correct
:compilation of atomic_intr_cond_try(). This hack should be removed once
:http://llvm.org/bugs/show_bug.cgi?id=3D3812 is solved. It is conditionalize=
:d on
:__clang__ define because it is not a valid syntax for gcc.
:
:Patch is at:
:http://gitweb.dragonflybsd.org/~alexh/dragonfly.git/commit/6e6c8028465bf25a=
:6e9f5685b57a3fee79f77382

Committed! Actually, cherry-picked from your leaf repo. That
sure makes it convenient!

-Matt

Also available in: Atom PDF