Bug #1582

Verbosity Patch for mount_hammer

Added by lentferj almost 5 years ago. Updated over 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Hi,

attached is a patch to increase verbosity of error messages for
mount_hammer. Also this is preparation for actually testing each
supplied device for mounting if it contains a valid hammer fs. Since you
can mount numerous devices onto one mountpoint it might be helpful to
actually know wich of the xx devices you typed on the commandline
actually prevented a successful mount.

Kind Regards,

Jan

PS: My first C coding in years, please be gentle :-)

patch_mount_hammer.c Magnifier (1.25 KB) lentferj, 10/21/2009 07:20 PM

patch2 (1.88 KB) lentferj, 10/24/2009 06:25 PM

pastie-668301.diff Magnifier (3.04 KB) lentferj, 10/25/2009 09:33 AM

patch_new.diff Magnifier (2.14 KB) lentferj, 11/01/2009 06:32 PM

History

#1 Updated by lentferj almost 5 years ago

With the help of tuxillo and corecode (and others on irc) I enhanced the
output a little more. If the mount fails it will now go through each
device named on the command line to check which one caused the fail and
will report this:

atom# ./mount_hammer /dev/dev1 /dev/ad11s2d /dev/dev2 /mnt
Not a valid HAMMER filesystem: /dev/dev1
Not a valid HAMMER filesystem: /dev/dev2
mount_hammer: mount /dev/dev1 /dev/dev2 on /mnt: Bad file descriptor

patch attached.

Cheers,

Jan

#2 Updated by lentferj almost 5 years ago

I'd like to take this one back. Lots of input from IRC that I want to
implement. Please forget about this patch.

Thanks

Jan

#3 Updated by lentferj over 4 years ago

This should now be the one.

Regards

Jan

#4 Updated by dillon over 4 years ago

:This should now be the one.
:
:Regards
:
:Jan

Looks good, I'll commit it.

-Matt

#5 Updated by dillon over 4 years ago

:This should now be the one.
:
:Regards
:
:Jan
:
:..
: filename="pastie-668301.diff"
:...

It didn't patch cleanly into the master branch. Could you regenerate
the patch relative to the master branch?

-Matt

#6 Updated by lentferj over 4 years ago

> It didn't patch cleanly into the master branch. Could you regenerate
> the patch relative to the master branch?
>
> -Matt

Hi Matt,

please find the update patch attached (git pull from 19:00 CET).

Cheers

Jan

#7 Updated by dillon over 4 years ago

:Hi Matt,
:
:please find the update patch attached (git pull from 19:00 CET).
:
:Cheers
:
:Jan

Excellent. Committed!

-Matt

Also available in: Atom PDF