Project

General

Profile

Actions

Bug #1582

closed

Verbosity Patch for mount_hammer

Added by lentferj over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hi,

attached is a patch to increase verbosity of error messages for
mount_hammer. Also this is preparation for actually testing each
supplied device for mounting if it contains a valid hammer fs. Since you
can mount numerous devices onto one mountpoint it might be helpful to
actually know wich of the xx devices you typed on the commandline
actually prevented a successful mount.

Kind Regards,

Jan

PS: My first C coding in years, please be gentle :-)


Files

patch_mount_hammer.c (1.25 KB) patch_mount_hammer.c lentferj, 10/21/2009 07:20 PM
patch2 (1.88 KB) patch2 lentferj, 10/24/2009 06:25 PM
pastie-668301.diff (3.04 KB) pastie-668301.diff lentferj, 10/25/2009 09:33 AM
patch_new.diff (2.14 KB) patch_new.diff lentferj, 11/01/2009 06:32 PM
Actions #1

Updated by lentferj over 14 years ago

With the help of tuxillo and corecode (and others on irc) I enhanced the
output a little more. If the mount fails it will now go through each
device named on the command line to check which one caused the fail and
will report this:

atom# ./mount_hammer /dev/dev1 /dev/ad11s2d /dev/dev2 /mnt
Not a valid HAMMER filesystem: /dev/dev1
Not a valid HAMMER filesystem: /dev/dev2
mount_hammer: mount /dev/dev1 /dev/dev2 on /mnt: Bad file descriptor

patch attached.

Cheers,

Jan

Actions #2

Updated by lentferj over 14 years ago

I'd like to take this one back. Lots of input from IRC that I want to
implement. Please forget about this patch.

Thanks

Jan

Actions #3

Updated by lentferj over 14 years ago

This should now be the one.

Regards

Jan

Actions #4

Updated by dillon over 14 years ago

:This should now be the one.
:
:Regards
:
:Jan

Looks good, I'll commit it.
-Matt
Actions #5

Updated by dillon over 14 years ago

:This should now be the one.
:
:Regards
:
:Jan
:
:..
: filename="pastie-668301.diff"
:...

It didn't patch cleanly into the master branch.  Could you regenerate
the patch relative to the master branch?
-Matt
Actions #6

Updated by lentferj over 14 years ago

It didn't patch cleanly into the master branch. Could you regenerate
the patch relative to the master branch?

-Matt

Hi Matt,

please find the update patch attached (git pull from 19:00 CET).

Cheers

Jan

Actions #7

Updated by dillon over 14 years ago

:Hi Matt,
:
:please find the update patch attached (git pull from 19:00 CET).
:
:Cheers
:
:Jan

Excellent.  Committed!
-Matt
Actions

Also available in: Atom PDF