https://bugs.dragonflybsd.org/
https://bugs.dragonflybsd.org/favicon.ico?1629395208
2010-07-11T16:39:49Z
DragonFlyBSD bugtracker
DragonFlyBSD - Bug #1785: ral(4) cardbus crash
https://bugs.dragonflybsd.org/issues/1785?journal_id=8716
2010-07-11T16:39:49Z
nthery
<ul></ul><p>[...]</p>
<blockquote>
<p><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: zombie processes waiting for a lock, smth to worry about? (Closed)" href="https://bugs.dragonflybsd.org/issues/14">#14</a> 0xc0296ccb in ral_pci_attach (dev=0xc14d3a58) at /usr/src/sys/dev/netif/ral/if_ral_pci.c:209</p>
</blockquote>
<p>It looks like sc_ifp is initialized after ifp = sc->sc_ifp.</p>
<p>Could you try this patch please?</p>
<p>diff --git a/sys/dev/netif/ral/if_ral_pci.c b/sys/dev/netif/ral/if_ral_pci.c<br />index 4af51b1..c94fad7 100644<br />--- a/sys/dev/netif/ral/if_ral_pci.c<br />+++ b/sys/dev/netif/ral/if_ral_pci.c<br /><code>@ -164,7 +164,7 </code>@ ral_pci_attach(device_t dev)
{<br /> struct ral_pci_softc *psc = device_get_softc(dev);<br /> struct rt2560_softc *sc = &psc->u.sc_rt2560;<br />- struct ifnet *ifp = sc->sc_ifp;<br />+ struct ifnet *ifp;<br /> int error;</p>
<pre><code>if (pci_get_powerstate(dev) != PCI_POWERSTATE_D0) {<br /><code>@ -202,6 +202,7 </code>@ ral_pci_attach(device_t dev)<br /> error = (*psc->sc_opns->attach)(dev, pci_get_device(dev));<br /> if (error != 0)<br /> return error;<br />+ ifp = sc->sc_ifp;</code></pre>
<pre><code>/*
* Hook our interrupt after all initialization is complete.</code></pre>
DragonFlyBSD - Bug #1785: ral(4) cardbus crash
https://bugs.dragonflybsd.org/issues/1785?journal_id=8722
2010-07-20T03:42:28Z
herrgard
<ul></ul><p>Nicolas Thery wrote:</p>
<blockquote>
<p>2010/6/21 Max Herrgård <<a class="email" href="mailto:herrgard@gmail.com">herrgard@gmail.com</a>>:</p>
<blockquote>
<p>Hi,</p>
<p>I get this crash when plugging in my ral(4) cardbus card.</p>
</blockquote>
<p>[...]</p>
<blockquote>
<p><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: zombie processes waiting for a lock, smth to worry about? (Closed)" href="https://bugs.dragonflybsd.org/issues/14">#14</a> 0xc0296ccb in ral_pci_attach (dev=0xc14d3a58) at /usr/src/sys/dev/netif/ral/if_ral_pci.c:209</p>
</blockquote>
<p>It looks like sc_ifp is initialized after ifp = sc->sc_ifp.</p>
<p>Could you try this patch please?</p>
<p>diff --git a/sys/dev/netif/ral/if_ral_pci.c b/sys/dev/netif/ral/if_ral_pci.c<br />index 4af51b1..c94fad7 100644<br />--- a/sys/dev/netif/ral/if_ral_pci.c<br />+++ b/sys/dev/netif/ral/if_ral_pci.c<br /><code>@ -164,7 +164,7 </code>@ ral_pci_attach(device_t dev)
{<br />struct ral_pci_softc *psc = device_get_softc(dev);<br />struct rt2560_softc *sc = &psc->u.sc_rt2560;<br />- struct ifnet *ifp = sc->sc_ifp;<br />+ struct ifnet *ifp;<br />int error;</p>
<p>if (pci_get_powerstate(dev) != PCI_POWERSTATE_D0) {<br /><code>@ -202,6 +202,7 </code>@ ral_pci_attach(device_t dev)<br />error = (*psc->sc_opns->attach)(dev, pci_get_device(dev));<br />if (error != 0)<br />return error;<br />+ ifp = sc->sc_ifp;</p>
/*
<ul>
<li>Hook our interrupt after all initialization is complete.</li>
</ul>
</blockquote>
<p>Yup. This patch fixes this crash.</p>
<p>Thank you,<br />Max</p>
DragonFlyBSD - Bug #1785: ral(4) cardbus crash
https://bugs.dragonflybsd.org/issues/1785?journal_id=8724
2010-07-22T02:07:31Z
herrgard
<ul></ul><p>Max Herrgård wrote:</p>
<blockquote>
<p>Nicolas Thery wrote:</p>
<blockquote>
<p>diff --git a/sys/dev/netif/ral/if_ral_pci.c b/sys/dev/netif/ral/if_ral_pci.c<br />index 4af51b1..c94fad7 100644<br />--- a/sys/dev/netif/ral/if_ral_pci.c<br />+++ b/sys/dev/netif/ral/if_ral_pci.c<br /><code>@ -164,7 +164,7 </code>@ ral_pci_attach(device_t dev)
{<br />struct ral_pci_softc *psc = device_get_softc(dev);<br />struct rt2560_softc *sc = &psc->u.sc_rt2560;<br />- struct ifnet *ifp = sc->sc_ifp;<br />+ struct ifnet *ifp;<br />int error;</p>
<p>if (pci_get_powerstate(dev) != PCI_POWERSTATE_D0) {<br /><code>@ -202,6 +202,7 </code>@ ral_pci_attach(device_t dev)<br />error = (*psc->sc_opns->attach)(dev, pci_get_device(dev));<br />if (error != 0)<br />return error;<br />+ ifp = sc->sc_ifp;</p>
/*
<ul>
<li>Hook our interrupt after all initialization is complete.</li>
</ul>
</blockquote>
<p>Yup. This patch fixes this crash.</p>
<p>Thank you,<br />Max</p>
</blockquote>
<p>However, this happens when I try to use it:</p>
<p>bender# ifconfig ral0 up<br />Jul 21 22:47:29 bender kernel: in6_ifattach_linklocal: failed to configure a link-local address on ral0 (errno=22)</p>
<p>bender# ifconfig wlan0 create wlandev ral0<br />wlan0: MAC address: 00:08:a1:a4:8d:97</p>
<p>...and then this crash comes when doing 'ifconfig wlan0 up':</p>
<p>Reading symbols from /usr/home/crash/kern.5...done.</p>
<p>Unread portion of the kernel message buffer:<br />ral0: need multicast update callback<br />panic: only BUS_DMA_NOWAIT is supported</p>
<p>Trace beginning at frame 0xc72ddb9c<br />panic(ffffffff) at panic+0x8e<br />panic(c062171c,c72ddc32,45e0d8,0,c723b0c0) at panic+0x8e<br />bus_dmamap_load_mbuf_segment(c14b3840,0,c9708d00,c72ddc20,1,c72ddc48,0) at bus_dmamap_load_mbuf_segment+0x6d<br />rt2661_raw_xmit(c6fb52b8,c9708d00,c72ddc96) at rt2661_raw_xmit+0x128<br />ieee80211_send_probereq(c6fb52b8,c723b364,c058d0c0,c058d0c0,c05c9174,0) at ieee80211_send_probereq+0x3c1<br />ieee80211_probe_curchan(c723b0c0,0) at ieee80211_probe_curchan+0xb3<br />scan_curchan(c70669c8,14,c6fb04b8,c6fb04b8,c6fb04cc) at scan_curchan+0x29<br />scan_task(c70669c8,1,c1423a20,c1423a3c,c06cbb18) at scan_task+0x2a4<br />taskqueue_run(c06cbb18,ff800000,0,c0322647,c6fb0534) at taskqueue_run+0x70<br />taskqueue_thread_loop(c6fb0534,0,0,0,0) at taskqueue_thread_loop+0x2b<br />lwkt_exit() at lwkt_exit<br />Debugger("panic")<br />panic: from debugger<br />Uptime: 54m58s<br />Physical memory: 215 MB<br />Dumping 48 MB: 33 17 1</p>
<p>Reading symbols from /boot/modules/vesa.ko...done.<br />Loaded symbols for /boot/modules/vesa.ko<br />Reading symbols from /boot/modules/acpi.ko...done.<br />Loaded symbols for /boot/modules/acpi.ko<br />_get_mycpu (di=0xc06d7980) at ./machine/thread.h:83<br /> in ./machine/thread.h<br />(kgdb) bt<br />#0 _get_mycpu (di=0xc06d7980) at ./machine/thread.h:83<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: lib/libcr/sys/ cleanup (Closed)" href="https://bugs.dragonflybsd.org/issues/1">#1</a> md_dumpsys (di=0xc06d7980) at /usr/src/sys/platform/pc32/i386/dump_machdep.c:263<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: K&R -> ANSI cleanup status (Closed)" href="https://bugs.dragonflybsd.org/issues/2">#2</a> 0xc0319ea1 in dumpsys () at /usr/src/sys/kern/kern_shutdown.c:839<br /><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: freebsds pipe-reverse test fails on dfly (Closed)" href="https://bugs.dragonflybsd.org/issues/3">#3</a> 0xc031a41c in boot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:388<br /><a class="issue tracker-1 status-5 priority-5 priority-high3 closed" title="Bug: Rework of nrelease (Closed)" href="https://bugs.dragonflybsd.org/issues/4">#4</a> 0xc031a542 in panic (fmt=0xc05adfb2 "from debugger") at /usr/src/sys/kern/kern_shutdown.c:745<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: sys/dev cleanup (Closed)" href="https://bugs.dragonflybsd.org/issues/5">#5</a> 0xc0178ad5 in db_panic (addr=-1068167144, have_addr=0, count=-1, modif=0xc72dda54 "") at /usr/src/sys/ddb/db_command.c:448<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: sys/emulation cleanup (Closed)" href="https://bugs.dragonflybsd.org/issues/6">#6</a> 0xc017914a in db_command () at /usr/src/sys/ddb/db_command.c:344<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: /sys/boot cleanup (Closed)" href="https://bugs.dragonflybsd.org/issues/7">#7</a> db_command_loop () at /usr/src/sys/ddb/db_command.c:470<br /><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: make upgrade broken (Closed)" href="https://bugs.dragonflybsd.org/issues/8">#8</a> 0xc017b758 in db_trap (type=3, code=0) at /usr/src/sys/ddb/db_trap.c:71<br /><a class="issue tracker-1 status-5 priority-5 priority-high3 closed" title="Bug: panic with HEAD (Closed)" href="https://bugs.dragonflybsd.org/issues/9">#9</a> 0xc0551184 in kdb_trap (type=3, code=0, regs=0xc72ddb4c) at /usr/src/sys/platform/pc32/i386/db_interface.c:152<br /><a class="issue tracker-1 status-5 priority-5 priority-high3 closed" title="Bug: make buildworld broken (Closed)" href="https://bugs.dragonflybsd.org/issues/10">#10</a> 0xc0563717 in trap (frame=0xc72ddb4c) at /usr/src/sys/platform/pc32/i386/trap.c:837<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: libstand cleanup (Closed)" href="https://bugs.dragonflybsd.org/issues/11">#11</a> 0xc0552557 in calltrap () at /usr/src/sys/platform/pc32/i386/exception.s:785<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: /sys/net cleanup (Closed)" href="https://bugs.dragonflybsd.org/issues/12">#12</a> 0xc0551018 in breakpoint (msg=0xc05c5eca "panic") at ./cpu/cpufunc.h:73<br /><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Buildworld error/panic (Closed)" href="https://bugs.dragonflybsd.org/issues/13">#13</a> Debugger (msg=0xc05c5eca "panic") at /usr/src/sys/platform/pc32/i386/db_interface.c:334<br /><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: zombie processes waiting for a lock, smth to worry about? (Closed)" href="https://bugs.dragonflybsd.org/issues/14">#14</a> 0xc031a539 in panic (fmt=0xc062171c "only BUS_DMA_NOWAIT is supported\n") at /usr/src/sys/kern/kern_shutdown.c:743<br /><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: savecore -z patch (Closed)" href="https://bugs.dragonflybsd.org/issues/15">#15</a> 0xc0550ced in bus_dmamap_load_mbuf_segment (dmat=0xc14b3840, map=0x0, m0=0xff800000, segs=0xc72ddc20, maxsegs=1, <br /> nsegs=0xc72ddc48, flags=<value optimized out>) at /usr/src/sys/platform/pc32/i386/busdma_machdep.c:882<br /><a class="issue tracker-1 status-5 priority-5 priority-high3 closed" title="Bug: install: net/bridge/*.h: No such file or directory (Closed)" href="https://bugs.dragonflybsd.org/issues/16">#16</a> 0xc029ea45 in rt2661_tx_mgt (ni=0xc6fb52b8, m=0xc9708d00, params=0xc72ddc96) at /usr/src/sys/dev/netif/ral/rt2661.c:1337<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: Minor typos (Closed)" href="https://bugs.dragonflybsd.org/issues/17">#17</a> rt2661_raw_xmit (ni=0xc6fb52b8, m=0xc9708d00, params=0xc72ddc96) at /usr/src/sys/dev/netif/ral/rt2661.c:1691<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: extern uint64_t tsc_frequency missing (Closed)" href="https://bugs.dragonflybsd.org/issues/18">#18</a> 0xc03bea87 in ieee80211_send_probereq (ni=0xc6fb52b8, sa=0xc723b364 "", <br /> da=0xc058d0c0 "\377\377\377\377\377\377ether_input_chain", bssid=0xc058d0c0 "\377\377\377\377\377\377ether_input_chain", <br /> ssid=0xc05c9174 "", ssidlen=0) at /usr/src/sys/netproto/802_11/wlan/ieee80211_output.c:1821<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: usched questions and a patch (Closed)" href="https://bugs.dragonflybsd.org/issues/19">#19</a> 0xc03c31a8 in ieee80211_probe_curchan (vap=0xc723b0c0, force=0) at /usr/src/sys/netproto/802_11/wlan/ieee80211_scan.c:791<br /><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: No detection of 8169S Gb interface (Closed)" href="https://bugs.dragonflybsd.org/issues/20">#20</a> 0xc03c3c01 in scan_curchan (ss=0xc70669c8, maxdwell=20) at /usr/src/sys/netproto/802_11/wlan/ieee80211_scan.c:809<br /><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: /etc/network.subr list_net_interfaces() fix (Closed)" href="https://bugs.dragonflybsd.org/issues/21">#21</a> 0xc03c3ed5 in scan_task (arg=0xc70669c8, pending=1) at /usr/src/sys/netproto/802_11/wlan/ieee80211_scan.c:940<br /><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: RealTek 8169S/8110S support. (Closed)" href="https://bugs.dragonflybsd.org/issues/22">#22</a> 0xc033bdbb in taskqueue_run (queue=0xc1423a20, lock_held=1) at /usr/src/sys/kern/subr_taskqueue.c:271<br />#23 0xc033bf4d in taskqueue_thread_loop (arg=0xc6fb0534) at /usr/src/sys/kern/subr_taskqueue.c:373<br /><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: waitpid() with WUNTRACED flag? (was Re: Hang on ctrl+Z after the MPSAFE tsleep/wakeup commit) (Closed)" href="https://bugs.dragonflybsd.org/issues/24">#24</a> 0xc0322647 in lwkt_deschedule_self (td=) at /usr/src/sys/kern/lwkt_thread.c:250<br />Backtrace stopped: previous frame inner to this frame (corrupt stack?)</p>
<p>Max</p>
DragonFlyBSD - Bug #1785: ral(4) cardbus crash
https://bugs.dragonflybsd.org/issues/1785?journal_id=8725
2010-07-22T04:31:27Z
josepht
<ul></ul><p>On Wed, Jul 21, 2010 at 09:06:03PM +0200, Max Herrg?rd wrote:</p>
<blockquote>
<p>Max Herrg?rd wrote:</p>
<p>However, this happens when I try to use it:</p>
<p>bender# ifconfig ral0 up<br />Jul 21 22:47:29 bender kernel: in6_ifattach_linklocal: failed to configure a link-local address on ral0 (errno=22)</p>
<p>bender# ifconfig wlan0 create wlandev ral0<br />wlan0: MAC address: 00:08:a1:a4:8d:97</p>
<p>...and then this crash comes when doing 'ifconfig wlan0 up':</p>
<p>Reading symbols from /usr/home/crash/kern.5...done.</p>
<p>Unread portion of the kernel message buffer:<br />ral0: need multicast update callback<br />panic: only BUS_DMA_NOWAIT is supported</p>
<p>Trace beginning at frame 0xc72ddb9c<br />panic(ffffffff) at panic+0x8e<br />panic(c062171c,c72ddc32,45e0d8,0,c723b0c0) at panic+0x8e<br />bus_dmamap_load_mbuf_segment(c14b3840,0,c9708d00,c72ddc20,1,c72ddc48,0) at bus_dmamap_load_mbuf_segment+0x6d</p>
</blockquote>
<p>In sys/dev/netif/ral/rt2661.c change the 0 at the end of the calls to<br />bus_dmamap_load_mbuf_segment to BUS_DMA_NOWAIT.</p>
<p>Thanks,<br />Joe</p>
DragonFlyBSD - Bug #1785: ral(4) cardbus crash
https://bugs.dragonflybsd.org/issues/1785?journal_id=8727
2010-07-23T15:05:55Z
nthery
<ul></ul><p>Thanks for testing it. I'll commit it this week-end.</p>
<p>2010/7/19 Max Herrgård <<a class="email" href="mailto:herrgard@gmail.com">herrgard@gmail.com</a>>:</p>
<blockquote>
<p>Nicolas Thery wrote:</p>
<blockquote>
<p>2010/6/21 Max Herrgård <<a class="email" href="mailto:herrgard@gmail.com">herrgard@gmail.com</a>>:</p>
<blockquote>
<p>Hi,</p>
<p>I get this crash when plugging in my ral(4) cardbus card.</p>
</blockquote>
<p>[...]</p>
<blockquote>
<p><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: zombie processes waiting for a lock, smth to worry about? (Closed)" href="https://bugs.dragonflybsd.org/issues/14">#14</a> 0xc0296ccb in ral_pci_attach (dev=0xc14d3a58) at /usr/src/sys/dev/netif/ral/if_ral_pci.c:209</p>
</blockquote>
<p>It looks like sc_ifp is initialized after ifp = sc->sc_ifp.</p>
<p>Could you try this patch please?</p>
<p>diff --git a/sys/dev/netif/ral/if_ral_pci.c b/sys/dev/netif/ral/if_ral_pci.c<br />index 4af51b1..c94fad7 100644<br />--- a/sys/dev/netif/ral/if_ral_pci.c<br />+++ b/sys/dev/netif/ral/if_ral_pci.c<br /><code>@ -164,7 +164,7 </code>@ ral_pci_attach(device_t dev)
{<br /> struct ral_pci_softc *psc = device_get_softc(dev);<br /> struct rt2560_softc *sc = &psc->u.sc_rt2560;<br />- struct ifnet *ifp = sc->sc_ifp;<br />+ struct ifnet *ifp;<br /> int error;</p>
<p> if (pci_get_powerstate(dev) != PCI_POWERSTATE_D0) {<br /><code>@ -202,6 +202,7 </code>@ ral_pci_attach(device_t dev)<br /> error = (*psc->sc_opns->attach)(dev, pci_get_device(dev));<br /> if (error != 0)<br /> return error;<br />+ ifp = sc->sc_ifp;</p>
<p> /*<br /> * Hook our interrupt after all initialization is complete.</p>
</blockquote>
<p>Yup. This patch fixes this crash.</p>
<p>Thank you,<br />Max</p>
</blockquote>
DragonFlyBSD - Bug #1785: ral(4) cardbus crash
https://bugs.dragonflybsd.org/issues/1785?journal_id=8729
2010-07-24T19:23:12Z
nthery
<ul></ul><p>Committed to master.</p>