https://bugs.dragonflybsd.org/https://bugs.dragonflybsd.org/favicon.ico?16293952082013-11-22T19:23:57ZDragonFlyBSD bugtrackerDragonFlyBSD - Submit #2607: [PATCH] Add proper const keywords to sysctl(3) parameters.https://bugs.dragonflybsd.org/issues/2607?journal_id=116482013-11-22T19:23:57ZkAworualex@kaworu.ch
<ul></ul><p>kAworu wrote:</p>
<blockquote>
<p>[...]<br />In particular I am unsure of r240176 (how is `name' tested for "validity"?).</p>
</blockquote>
<p>OK I think I got it: that's because sys___sysctl() begin by copyin(9) `name' which will return EFAULT if a bad address is encoutered.</p> DragonFlyBSD - Submit #2607: [PATCH] Add proper const keywords to sysctl(3) parameters.https://bugs.dragonflybsd.org/issues/2607?journal_id=116522013-11-23T12:27:03ZkAworualex@kaworu.ch
<ul></ul><p>As additional tests I've run `sysctl -a' and `sysctl -ad' with and without the patch. As expected, The `sysctl -ad' output was the same and `sysctl -a' revealed expected diff for some values (load average, vm stats vfs cache etc.).</p> DragonFlyBSD - Submit #2607: [PATCH] Add proper const keywords to sysctl(3) parameters.https://bugs.dragonflybsd.org/issues/2607?journal_id=116532013-11-23T16:00:03Zeadlerlists@eitanadler.com
<ul></ul><p>These patches look reasonable to me.</p> DragonFlyBSD - Submit #2607: [PATCH] Add proper const keywords to sysctl(3) parameters.https://bugs.dragonflybsd.org/issues/2607?journal_id=116542013-11-25T00:25:59Zswildner
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Pushed (00f0918d338a0f863b786ed4565f12971eaecdc8).</p>
<p>Thanks!</p>