Project

General

Profile

Bug #2759

hammer(8) doesn't respect the timelimit for deduplication

Added by ftigeot about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Userland
Target version:
Start date:
01/05/2015
Due date:
% Done:

100%

Estimated time:

Description

Environment:
- a storage server with a 20TB /data volume
- a dataset potentially deduplication-friendly (protein sequences)
- deduplication has been enabled with a 5mn per day timelimit for /data

Problem:
- hammer(8) is running most of the day, inducing a high background I/O load on the disks
- the particular command is "hammer -t 300 dedup"

That command is run from the nightly hammer cleanup cron. It starts at 3am an never finishes.

A quick test on a brand new hammer volume confirms the -t argument to hammer dedup has no effect.
hammer dedup will run forever as long as there is still data to deduplicate.


Files

cmd_dedup01.diff (3.86 KB) cmd_dedup01.diff tuxillo, 01/07/2015 04:14 PM

History

#1

Updated by tuxillo about 5 years ago

  • File cmd_dedup01.diff cmd_dedup01.diff added
  • Category set to Userland
  • Status changed from New to Feedback
  • Assignee set to tuxillo
  • Priority changed from Normal to High
  • Target version set to 4.2.x

Hi,

Please try the patch attached (in non Prod systems) and see if it works correctly.

Cheers,
Antonio Huete

#2

Updated by ftigeot about 5 years ago

  • % Done changed from 0 to 90

Thanks for the patch.

It appears to work perfectly fine on a test box.

#3

Updated by ftigeot about 5 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Fix pushed to -master as 3a92efe3ce8f11b83b469609135c5fedaafa6632 .

Also available in: Atom PDF