Bug #277

xlint(1) patch

Added by bill.marquette about 8 years ago. Updated almost 8 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Looks like lint won't run with gcc 3 w/out some tweaks. Here's a
patch that allows lint to run (noisily) against itself, stolen from
OpenBSD; probably it ought to be sync'd again from NetBSD where it
came from, this at least allows it to "do something" again.

--Bill

Index: usr.bin/xlint/xlint/xlint.c
===================================================================
RCS file: /home/dcvs/src/usr.bin/xlint/xlint/xlint.c,v
retrieving revision 1.11
diff -u -r1.11 xlint.c
--- usr.bin/xlint/xlint/xlint.c 5 Apr 2005 08:19:35 -0000 1.11
+++ usr.bin/xlint/xlint/xlint.c 6 Jul 2006 22:59:29 -0000
@@ -308,9 +308,19 @@
libs = xcalloc(1, sizeof (char *));
libsrchpath = xcalloc(1, sizeof (char *));

- appcstrg(&cppflags, "-lang-c");
+ appcstrg(&cppflags, "-x");
+ appcstrg(&cppflags, "c");
+ appcstrg(&cppflags, "-undef");
+ /* even with -undef cpp still identifies as GNUC */
+ appcstrg(&cppflags, "-U__GNUC__");
+#if defined(__GNUC__)
+#if __GNUC__ < 3
appcstrg(&cppflags, "-$");
appcstrg(&cppflags, "-C");
+#else
+ appcstrg(&cppflags, "-CC");
+#endif
+#endif
appcstrg(&cppflags, "-Wcomment");
#ifdef __DragonFly__
appcstrg(&cppflags, "-D__DragonFly__=" __XSTRING(__DragonFly__));

History

#1 Updated by bill.marquette almost 8 years ago

Not sure if this got missed, or if someone was waiting on something
else. lint doesn't work at all right now w/out this patch. Also at
http://www.pfsense.org/~billm/dfly/xlint.patch

--Bill

On 8/2/06, Bill Marquette <> wrote:
> Looks like lint won't run with gcc 3 w/out some tweaks. Here's a
> patch that allows lint to run (noisily) against itself, stolen from
> OpenBSD; probably it ought to be sync'd again from NetBSD where it
> came from, this at least allows it to "do something" again.
>
> --Bill
>
> Index: usr.bin/xlint/xlint/xlint.c
> ===================================================================
> RCS file: /home/dcvs/src/usr.bin/xlint/xlint/xlint.c,v
> retrieving revision 1.11
> diff -u -r1.11 xlint.c
> --- usr.bin/xlint/xlint/xlint.c 5 Apr 2005 08:19:35 -0000 1.11
> +++ usr.bin/xlint/xlint/xlint.c 6 Jul 2006 22:59:29 -0000
> @@ -308,9 +308,19 @@
> libs = xcalloc(1, sizeof (char *));
> libsrchpath = xcalloc(1, sizeof (char *));
>
> - appcstrg(&cppflags, "-lang-c");
> + appcstrg(&cppflags, "-x");
> + appcstrg(&cppflags, "c");
> + appcstrg(&cppflags, "-undef");
> + /* even with -undef cpp still identifies as GNUC */
> + appcstrg(&cppflags, "-U__GNUC__");
> +#if defined(__GNUC__)
> +#if __GNUC__ < 3
> appcstrg(&cppflags, "-$");
> appcstrg(&cppflags, "-C");
> +#else
> + appcstrg(&cppflags, "-CC");
> +#endif
> +#endif
> appcstrg(&cppflags, "-Wcomment");
> #ifdef __DragonFly__
> appcstrg(&cppflags, "-D__DragonFly__=" __XSTRING(__DragonFly__));
>

#2 Updated by corecode almost 8 years ago

Thanks, committed!

Also available in: Atom PDF