https://bugs.dragonflybsd.org/https://bugs.dragonflybsd.org/favicon.ico?16293952082017-11-24T22:03:29ZDragonFlyBSD bugtrackerDragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133232017-11-24T22:03:29Zdaftaupepierre-alain@toret.fr
<ul><li><strong>File</strong> <i>patch-Makefile.usr</i> added</li></ul><p>Would something like this patch work for you ?</p>
<p>First this check for dports directory existence in dports-check, not dports/.git, which for the same reason you mention shouldn't exist. Then I removed the dependency to git-check.<br />Then I changed the dependency of dports-create-shallow to a new target : dports-check-shallow, that has git-check has a dependency.</p>
<p>I wasn't sure about the name of the new target. Let me know what do you think of that.</p>
<p>Regards,</p> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133242017-11-24T22:09:59Zdaftaupepierre-alain@toret.fr
<ul><li><strong>File</strong> deleted (<del><i>patch-Makefile.usr</i></del>)</li></ul> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133252017-11-24T22:10:25Zdaftaupepierre-alain@toret.fr
<ul><li><strong>File</strong> <a href="/attachments/1488">patch-Makefileusr.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1488/patch-Makefileusr.patch">patch-Makefileusr.patch</a> added</li></ul> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133262017-11-25T15:43:20ZAnonymous
<ul></ul><p>This looks good to me. Thank you!</p> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133292017-11-28T16:27:54Zftigeot
<ul></ul><p>The latest patch is indeed an improvement for the dports-download target.<br />Unfortunately, it also removes the dports-create target git check.</p>
<p>dports-create depends on git being present.<br />IMHO, it would be better to add a dports-download check than to modify the existing dports-check one.</p> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133302017-11-29T09:44:22Zdaftaupepierre-alain@toret.fr
<ul><li><strong>File</strong> <a href="/attachments/1492">0001-Add-dports-download-check-target.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1492/0001-Add-dports-download-check-target.patch">0001-Add-dports-download-check-target.patch</a> added</li><li><strong>File</strong> <a href="/attachments/1493">0002-Add-test-to-dports-download-check-target.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1493/0002-Add-test-to-dports-download-check-target.patch">0002-Add-test-to-dports-download-check-target.patch</a> added</li></ul><p>Hello ftigeot,</p>
<p>thanks for taking the time to review my patch.<br />Here is a new one that adds a dports-download check target as you suggested.<br />I added a second one that adds a test for /usr/DragonflyBSD-DPorts-* dirs, as I noticed that if you break dports-download during the extraction of the .tar.gz archive, you end up with a temporary dir like this, and it makes the mv command failed next time it's run. As such :<br />rm <del>f /tmp/dports.tar.gz<br />fetch -o /tmp/dports.tar.gz <a class="external" href="https://api.github.com/repos/DragonFlyBSD/DPorts/tarball/">https://api.github.com/repos/DragonFlyBSD/DPorts/tarball/</a><br />fetch: <a class="external" href="https://api.github.com/repos/DragonFlyBSD/DPorts/tarball/">https://api.github.com/repos/DragonFlyBSD/DPorts/tarball/</a>: size of remote file is not known<br />/tmp/dports.tar.gz 42 MB 3535 kBps 00m13s<br />tar -xf /tmp/dports.tar.gz -C /usr<br />mv /usr/DragonFlyBSD-DPorts</del>* /usr/dports<br />usage: mv [-f | -i | -n] [-hv] source target<br /> mv [-f | -i | -n] [-v] source ... directory</p>
<p>Regards,</p> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133432017-12-08T21:45:57Zftigeot
<ul><li><strong>Assignee</strong> set to <i>ftigeot</i></li></ul> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133442017-12-08T22:45:41Zftigeot
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>50</i></li></ul><p>First patch looks good, pushed.</p> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133462017-12-09T20:55:12Zftigeot
<ul><li><strong>% Done</strong> changed from <i>50</i> to <i>90</i></li></ul><p>The second commit also looked good and has been pushed today.<br />Thanks for the patches !</p> DragonFlyBSD - Bug #3053: Makefile.usr: target dports-download has incorrect dependencyhttps://bugs.dragonflybsd.org/issues/3053?journal_id=133512017-12-16T08:51:36Zftigeot
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul>