Project

General

Profile

Bug #3076

sys/dev/netif/ig_hal/e1000_ich8lan.c:1594: sanity checking mixup ?

Added by dcb 8 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
10/11/2017
Due date:
% Done:

0%


Description

dragonfly/sys/dev/netif/ig_hal/e1000_ich8lan.c:1594] -> [dragonfly/sys/dev/netif/ig_hal/e1000_ich8lan.c:1607]: (warning) Identical condition 'ret_val', second condition is always false

Source code is

hw->phy.ops.release(hw);

if (ret_val)
return ret_val;

If release returns a value, then suggest check it, otherwise
suggest remove redundant check.

Also available in: Atom PDF