Project

General

Profile

Actions
Copy link

Bug #3083

closed

crypto/openssh/auth2-pubkey.c:186]: (style) Suspicious condition

Added by dcb about 7 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
10/17/2017
Due date:
% Done:

0%

Estimated time:

Description

crypto/openssh/auth2-pubkey.c:186]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

if ((r = sshbuf_put_cstring(b, "publickey")) != 0 ||
                (r = sshbuf_put_u8(b, have_sig)) != 0 ||
                (r = sshbuf_put_cstring(b, pkalg) != 0))

Maybe better code

if ((r = sshbuf_put_cstring(b, "publickey")) != 0 ||
                (r = sshbuf_put_u8(b, have_sig)) != 0 ||
                (r = sshbuf_put_cstring(b, pkalg)) != 0)
Actions
Copy link
 #1

Updated by deef over 4 years ago

  • Status changed from New to Closed

Discussed with swildner on IRC, this should be reported to upstream and DragonFly will import the change when it's updated there.

Actions
Copy link

Also available in: Atom PDF