https://bugs.dragonflybsd.org/
https://bugs.dragonflybsd.org/favicon.ico?1629395208
2006-01-22T03:11:20Z
DragonFlyBSD bugtracker
DragonFlyBSD - Bug #79: ncp patch
https://bugs.dragonflybsd.org/issues/79?journal_id=246
2006-01-22T03:11:20Z
dillon
<ul></ul><p>Nice catch! I am going to switch around the m_getm() <br /> argument declarations instead of switching the arguments as<br /> the memory 'how' is typically the last argument for other<br /> calls.</p>
<pre><code>-Matt<br /> Matthew Dillon <br /> &lt;<a class="email" href="mailto:dillon@backplane.com">dillon@backplane.com</a>&gt;</code></pre>
<p>:Hi,<br />:<br />:1) Swap m_getm arguments to correct order<br />:<br />:--------------090804060400040407050500<br />:Content-Type: text/plain;<br />: name="ncp.diff" <br />:Content-Transfer-Encoding: 7bit<br />:Content-Disposition: inline;<br />: filename="ncp.diff" <br />:<br />:Index: ./netproto/ncp/ncp_rq.c<br />:===================================================================<br />:RCS file: /mnt/share/dragonfly-cvs/src/sys/netproto/ncp/ncp_rq.c,v<br />:retrieving revision 1.9<br />:diff <del>u -r1.9 ncp_rq.c<br />:--</del> ./netproto/ncp/ncp_rq.c 14 Jan 2006 13:36:40 <del>0000 1.9<br />:+++ ./netproto/ncp/ncp_rq.c 20 Jan 2006 17:45:15 -0000<br />:<code>@ -158,7 +158,7 </code>@<br />: m</del>>m_len <ins>= cplen;<br />: }<br />: if (size) {<br />:- m_getm(m, size, MT_DATA, MB_WAIT);<br />:</ins> m_getm(m, size, MB_WAIT, MT_DATA);<br />: while (size > 0){<br />: m = m->m_next;<br />: cplen = min(size, M_TRAILINGSPACE(m));<br />:<code>@ -191,7 +191,7 </code>@<br />: m->m_len <ins>= cplen;<br />: }<br />: if (size) {<br />:- m_getm(m, size, MT_DATA, MB_WAIT);<br />:</ins> m_getm(m, size, MB_WAIT, MT_DATA);<br />: while (size > 0){<br />: m = m->m_next;<br />: cplen = min(size, M_TRAILINGSPACE(m));</p>