Bug #803

Fix a bug in route(8)

Added by nant over 6 years ago. Updated over 6 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Hi,

The attached patch allows "route add 128/8 <gateway>" to work
correctly. While here, rectify the way netmasks are deduced from the
address class.

Please verify.

Noticed-by: Tom Judge <>
Reported-on: freebsd-net mailing list

Thanks,
Nuno

sbin.route.patch Magnifier (1.38 KB) nant, 09/09/2007 03:27 PM

netstat-cidr.patch Magnifier (1.14 KB) nant, 09/10/2007 05:43 PM

History

#1 Updated by dillon over 6 years ago

:Hi,
:
:The attached patch allows "route add 128/8 <gateway>" to work
:correctly. While here, rectify the way netmasks are deduced from the
:address class.
:
:Please verify.
:
:Noticed-by: Tom Judge <>
:Reported-on: freebsd-net mailing list
:
:Thanks,
:Nuno

Works here. I noticed something while testing it... netstat -rn
(display routes) is not displaying CIDR blocks properly. Look:

Internet:
Destination Gateway Flags Refs Use Netif Expire
127.0.0.1 127.0.0.1 UH 0 183 lo0
128.0/8 216.240.41.5 UGSc 0 0 nfe0

That should read 128/8, not 128.0/8. It's mixing the core classes
with the CIDR specification.

Would you like to have a go at fixing that, too?

If nobody reports any bugs I'll commit your route patch on Monday.

-Matt

#2 Updated by nant over 6 years ago

Yeah, I've seen that too. I think that netstat should be teached
better regarding CIDR. I'll have a look at it during this week.

Thanks,
Nuno

#3 Updated by nant over 6 years ago

Hi,

I think this fixes netstat.

Thanks,
Nuno

#4 Updated by sepherosa over 6 years ago

Committed. Thanks!

Best Regards,
sephe

Also available in: Atom PDF