Project

General

Profile

Actions
Copy link

Bug #1166

closed

fix random setsockopt failure (EINVAL)

Added by sepherosa about 16 years ago. Updated about 16 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hi all,

Following patch should fix random setsockopt failure (EINVAL) in HEAD:
http://leaf.dragonflybsd.org/~sephe/sockopt.diff

In addition to that:
- Don't do copyout in setsockopt; the user arg is const
- Always setup sopt (i.e. set sopt.sopt_val to NULL early)
- In sys_getsocktopt(), centralize valsize check

Please review/test it.

Best Regard,
sephe

Actions
Copy link
 #1

Updated by aoiko about 16 years ago

Looks good. Feeling a bit embarrassed btw :)

Aggelos

Actions
Copy link
 #2

Updated by aoiko about 16 years ago

committed by sephe

Actions
Copy link

Also available in: Atom PDF