Project

General

Profile

Actions

Submit #1192

open

KKASSERTs in sys/kern/uipc_{msg,socket}.c are too strict

Added by rumcic about 15 years ago. Updated almost 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Kernel
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The code for nfs root mounts does not use kmalloc-ed space for some vars, while
some KKASSERTs in the mentioned files only check for the supplied pointers if
they were kmalloc-ed or not.
The attached patch adds a check if the supplied pointers are not in user stack
(if they are in kernel stack) ... since kmalloc-ed space also resides in the
addresses not in user stack, maybe kva_p should be removed (is it used
anywhere else?)?
--
Regards,
Rumko


Files

rootnfs.patch (2.63 KB) rootnfs.patch rumcic, 12/29/2008 10:05 PM
Actions #1

Updated by corecode about 15 years ago

has this been fixed?

Actions #2

Updated by rumcic almost 15 years ago

No, not yet. (Sorry for the late response)

Actions #3

Updated by tuxillo about 9 years ago

  • Tracker changed from Bug to Submit
  • Description updated (diff)
  • Category set to Kernel
  • Assignee deleted (alexh)
  • Priority changed from High to Normal
  • Target version set to 4.2

Hi,

Indeed, kva_p() is only used in uipc_msg.c and uipc_socket.c
Matt, what do you think about the attached patch?

Cheers,
Antonio Huete

Actions #4

Updated by tuxillo almost 3 years ago

  • Target version changed from 4.2 to 6.0
Actions

Also available in: Atom PDF