Project

General

Profile

Actions

Bug #1617

closed

top - move top to vendor/TOP and update to 3.8beta1

Added by lentferj about 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Relevant bits are here:

http://gitweb.dragonflybsd.org/~lentferj/dragonfly.git/shortlog/refs/heads/top_update
http://gitweb.dragonflybsd.org/~lentferj/dragonfly.git/shortlog/refs/heads/vendor/TOP

This version of top defaults to diplay CPU on a single line. Multiline
CPU dislay can be enabled with "-M".

Regards,

Jan


Files

m_dragonfly_w_cleanup.patch (38.4 KB) m_dragonfly_w_cleanup.patch lentferj, 12/05/2009 10:29 AM
Actions #1

Updated by TGEN about 12 years ago

Jan Lentfer wrote:

This version of top defaults to diplay CPU on a single line. Multiline
CPU dislay can be enabled with "-M".

Why not C as on FreeBSD?
-

Thomas E. Spanjaard

Actions #2

Updated by lentferj about 12 years ago

Jan Lentfer schrieb:

Relevant bits are here:

http://gitweb.dragonflybsd.org/~lentferj/dragonfly.git/shortlog/refs/heads/top_update

http://gitweb.dragonflybsd.org/~lentferj/dragonfly.git/shortlog/refs/heads/vendor/TOP

This version of top defaults to diplay CPU on a single line. Multiline
CPU dislay can be enabled with "-M".

I just figured out that it is not working on i386 (I made the patches on
x86_64). So be aware that this will only work on x86_64. Also man page
is broken (fixed that already). Will commit all the fixes with i386-fix.

Jan

Actions #3

Updated by lentferj about 12 years ago

-C is taken for "Color" mode in 3.8beta1.

Actions #4

Updated by lentferj about 12 years ago

Jan Lentfer schrieb:

Jan Lentfer schrieb:

Relevant bits are here:

http://gitweb.dragonflybsd.org/~lentferj/dragonfly.git/shortlog/refs/heads/top_update

http://gitweb.dragonflybsd.org/~lentferj/dragonfly.git/shortlog/refs/heads/vendor/TOP

This version of top defaults to diplay CPU on a single line. Multiline
CPU dislay can be enabled with "-M".

I just figured out that it is not working on i386 (I made the patches on
x86_64). So be aware that this will only work on x86_64. Also man page
is broken (fixed that already). Will commit all the fixes with i386-fix.

The problems are fixed and this should be ready now. Along the way I
also fixed a problem in the original top source that would lead to
segfault when passing wrong number of arguments to renice function.

Jan

Actions #5

Updated by lentferj about 12 years ago

As discussed on IRC attached is the style and unused code cleanup patch
for usr.bin/top/m_dragonfly.c

Cheers

Jan

Actions #6

Updated by lentferj about 12 years ago

Committed.

Actions

Also available in: Atom PDF