Project

General

Profile

Actions

Submit #2525

closed

[PATCH] Small Fixes

Added by Gwenio over 11 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Fixes an array out of bounds error in usr.bin/shlock/shlock.c. The fix reduces the offset accessed where the error occurs, but increasing the size of the local variable 'buf' to BUFSIZE + 1 would also be a valid fix.

The other changes to the other files are trivial changes to make other code more 'correct' by having it follow strict aliasing rules. As such they are not important unless the code is being compiled with -O2 or higher.


Files

Actions #1

Updated by tuxillo over 11 years ago

  • Status changed from New to In Progress

Hi,

shlock(1) patch has been pushed. We are assessing the rest of the patches.

Thanks,
Antonio Huete

Actions #2

Updated by swildner about 3 years ago

  • Description updated (diff)
  • Status changed from In Progress to Closed

I've pushed the rest of it too. They are only relevant for GCC 4.7.3, but doesn't hurt anyway.

Actions

Also available in: Atom PDF