https://bugs.dragonflybsd.org/https://bugs.dragonflybsd.org/favicon.ico?16293952082014-08-22T12:52:11ZDragonFlyBSD bugtrackerDragonFlyBSD - Submit #2717: Out of range numeric handlinghttps://bugs.dragonflybsd.org/issues/2717?journal_id=121972014-08-22T12:52:11Zdclinkdevnexen@gmail.com
<ul><li><strong>Subject</strong> changed from <i>Sysctl out of range numeric handling handling</i> to <i>Sysctl out of range numeric handling</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul> DragonFlyBSD - Submit #2717: Out of range numeric handlinghttps://bugs.dragonflybsd.org/issues/2717?journal_id=121992014-08-22T12:53:39Zdclinkdevnexen@gmail.com
<ul><li><strong>Target version</strong> set to <i>3.9.x</i></li></ul> DragonFlyBSD - Submit #2717: Out of range numeric handlinghttps://bugs.dragonflybsd.org/issues/2717?journal_id=122012014-08-22T13:37:36Zdclinkdevnexen@gmail.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li></ul> DragonFlyBSD - Submit #2717: Out of range numeric handlinghttps://bugs.dragonflybsd.org/issues/2717?journal_id=122132014-08-24T07:27:24Zdclinkdevnexen@gmail.com
<ul><li><strong>File</strong> deleted (<del><i>diff-sysctl.c</i></del>)</li></ul> DragonFlyBSD - Submit #2717: Out of range numeric handlinghttps://bugs.dragonflybsd.org/issues/2717?journal_id=122142014-08-24T07:29:33Zdclinkdevnexen@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/1139">patch-atoi.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1139/patch-atoi.txt">patch-atoi.txt</a> added</li><li><strong>Subject</strong> changed from <i>Sysctl out of range numeric handling</i> to <i>Out of range numeric handling</i></li><li><strong>Category</strong> changed from <i>Kernel</i> to <i>Userland</i></li></ul><p>Finally made more out of range handling in some base utilities. For example vi with a wrong COLUMNS env var led to segmentation fault. Ported small fixes in ifconfig 80211 part from FreeBSD (use of d value instead of atoi(val) when it was necessary) and so on.</p> DragonFlyBSD - Submit #2717: Out of range numeric handlinghttps://bugs.dragonflybsd.org/issues/2717?journal_id=124252015-01-15T00:20:08Ztuxillo
<ul><li><strong>Target version</strong> changed from <i>3.9.x</i> to <i>4.2</i></li></ul><p>Grab</p> DragonFlyBSD - Submit #2717: Out of range numeric handlinghttps://bugs.dragonflybsd.org/issues/2717?journal_id=125622015-01-24T00:23:44Ztuxillo
<ul><li><strong>Assignee</strong> set to <i>tuxillo</i></li><li><strong>% Done</strong> changed from <i>100</i> to <i>0</i></li></ul><p>Hi,</p>
<p>The patch looks okay besides a few wrong tabs which is really minor.<br />But I'd like to understand why you don't use strtonum() more consistently, for example you use strtol() and an ERANGE check in some other places:</p>
<p>- dtrwait = atoi(argv<sup><a href="#fn3">3</a></sup>);<br />+ dtrwait = strtol(argv<sup><a href="#fn3">3</a></sup>, NULL, 10);<br />+ if (errno == ERANGE)<br />+ usage();</p>
<p>Cheers,<br />Antonio Huete</p> DragonFlyBSD - Submit #2717: Out of range numeric handlinghttps://bugs.dragonflybsd.org/issues/2717?journal_id=140612021-05-11T11:08:03Ztuxillo
<ul><li><strong>Target version</strong> changed from <i>4.2</i> to <i>6.0</i></li></ul>