https://bugs.dragonflybsd.org/https://bugs.dragonflybsd.org/favicon.ico?16293952082014-09-03T13:34:40ZDragonFlyBSD bugtrackerDragonFlyBSD - Bug #2722: bpf_filter's memory array is signedhttps://bugs.dragonflybsd.org/issues/2722?journal_id=122212014-09-03T13:34:40Zsepherosa
<ul></ul><p>Fixed, thank!</p>
<p>On Wed, Sep 3, 2014 at 2:15 AM, <<a class="email" href="mailto:bugtracker-admin@leaf.dragonflybsd.org">bugtracker-admin@leaf.dragonflybsd.org</a>> wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: bpf_filter's memory array is signed (Closed)" href="https://bugs.dragonflybsd.org/issues/2722">#2722</a> has been reported by guy.</p>
<p>----------------------------------------<br />Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: bpf_filter's memory array is signed (Closed)" href="https://bugs.dragonflybsd.org/issues/2722">#2722</a>: bpf_filter's memory array is signed<br /><a class="external" href="http://bugs.dragonflybsd.org/issues/2722">http://bugs.dragonflybsd.org/issues/2722</a></p>
<ul>
<li>Author: guy</li>
<li>Status: New</li>
<li>Priority: Normal</li>
<li>Assignee:</li>
<li>Category: Networking</li>
<li>Target version:<br />----------------------------------------<br />The mem[] array in bpf_filter(), for scratch memory in BPF programs, is an array of signed 32-bit integers. However, 1) all references to it either assign unsigned 32-bit values to elements in the array or assign the value of elements in the array to unsigned 32-bit values, and in some other BSDs it's unsigned.</li>
</ul>
<p>This shouldn't affect the behavior of the code (at least on 2's-complement machines, but I don't foresee a Univac 2200-series port of any of the BSDs any time soon :-)), but it makes it a bit cleaner and more like some other BSDs (the others will get their own patches) and the current top-of-trunk libpcap.</p>
<p>I've attached a fix.</p>
<p>---Files--------------------------------<br />patch (376 Bytes)</p>
<p>--<br />You have received this notification because you have either subscribed to it, or are involved in it.<br />To change your notification preferences, please click here: <a class="external" href="http://bugs.dragonflybsd.org/my/account">http://bugs.dragonflybsd.org/my/account</a></p>
</blockquote>
<p>-- <br />Tomorrow Will Never Die</p> DragonFlyBSD - Bug #2722: bpf_filter's memory array is signedhttps://bugs.dragonflybsd.org/issues/2722?journal_id=122242014-09-03T19:43:08Zswildner
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>It was pushed (05b1e6eac15534d3ea7e33de2cbccc3d08a286d4)</p>