Project

General

Profile

Actions

Bug #3028

closed

installer: confusion of set/get disk encryption passphrase dialogs

Added by liweitianux almost 7 years ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Other
Target version:
Start date:
04/14/2017
Due date:
% Done:

100%

Estimated time:

Description

Currently, the installer uses the same dialog to "set" and "get" the passphrase for disk encryption, which causes some confusion, as well as a bit inconvenience.

The followings are the 2 cases to come across the confusing "get" passphrase dialog:

1. installation finished, begins to configure the system, which will ask the disk encryption passphrase;
2. boot into the LiveCD, and use it to "Configure an installed System" (see attached screenshots).

The corresponding code is at "usr.sbin/installer/dfuibe_installer/fn_configure.c" with the function "fn_get_passphrase()". It may be better to create separate functions for the "set" and "get" passphrase dialogs, respectively.

Cheers,
Aly


Files

dfly_4.8_encryption_passphrase.png (18.4 KB) dfly_4.8_encryption_passphrase.png screenshots for "get" passphrase dialog confusion liweitianux, 04/13/2017 11:33 PM
fn_get_passphrase.patch (5.56 KB) fn_get_passphrase.patch tuxillo, 06/03/2022 05:12 PM
Actions #1

Updated by tuxillo almost 2 years ago

Maybe something like this would work? (Untested!!)

Actions #2

Updated by liweitianux about 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Fixed in master and 6.4 branches.

Thanks tuxillo for the initial patch.

Actions

Also available in: Atom PDF