https://bugs.dragonflybsd.org/https://bugs.dragonflybsd.org/favicon.ico?16293952082007-05-30T04:57:02ZDragonFlyBSD bugtrackerDragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=28302007-05-30T04:57:02Zswildner
<ul></ul><p>Never mind IFM_CARP. At the time I suggested this to Jonathan, I didn't <br />check NetBSD (which, as you noted, didn't put this in their ifmedia(4)).</p>
<p>Don't worry. Looks fine and we can sort the details out afterwards. <br />Let's see what Scott finds in testing the patch.</p>
<p>Sascha</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=34822007-08-08T01:50:02Zbastyaelvtars
<ul></ul><p>On Tue, 29 May 2007 22:14:49 +0200<br />Baptiste Ritter <<a class="email" href="mailto:baptiste.ritter@ulp.u-strasbg.fr">baptiste.ritter@ulp.u-strasbg.fr</a>> wrote:</p>
<p>Hi,</p>
<p>yesterday I said that the patch applies cleanly. This is not true, I<br />get:</p>
<p>patch: <strong>**</strong> malformed patch at line 931: <code>@ -801,8 +821,10 </code>@<br />in_arpinput(struct mbuf *m)</p>
<p>and it stops.</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=34892007-08-09T03:45:02Zbaptiste.ritter
<ul></ul><p>I just tried the patch on the two following tarballs:<br />- src-Release-1.10.tar.bz2 66315 KB 06.08.2007 13:11:00<br />- src-Devel.tar.bz2 66990 KB 08.08.2007 01:10:00</p>
<p>The both operation terminated with success.</p>
<p>May be, your patch files is damaged ; you should directly wget the file<br />from <a class="external" href="http://bugs.dragonflybsd.org/file261/carp-20070529BR01.patch">http://bugs.dragonflybsd.org/file261/carp-20070529BR01.patch</a></p>
<p>For information, the version of my patch software is 2.0-12u8-OpenBSD<br />and my md5sum of the "wgeted" file is fa0361adf7c2a34a92f7637278e44b3f</p>
<p>Regards,</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=34902007-08-09T06:09:03Zbastyaelvtars
<ul></ul><p>On Wed, 08 Aug 2007 21:43:28 +0200<br />Baptiste Ritter <<a class="email" href="mailto:baptiste.ritter@ulp.u-strasbg.fr">baptiste.ritter@ulp.u-strasbg.fr</a>> wrote:</p>
<p>I was thinking the same and tried 3 different ways but looks like the<br />attachment got corrupted somehow, because even extracting from the mail<br />archive site's code failed, not to talk of FTP, Samba and other<br />protocols.</p>
<p>Either way, this works. Thank you, and I'll insult you next week if I<br />have errors. I did RTFM, so I know what I should do.</p>
<p>Se you soon,</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35022007-08-10T09:38:39Zthomas.nikolajsen
<ul></ul><p>Please update carp(4) SYNOPSIS to:<br />options CARP<br />pseudo-device carp<br />(not 'device carp').</p>
<pre><code>-thomas</code></pre> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35142007-08-12T02:38:03Zbaptiste.ritter
<ul></ul><p>Done ; the new patch is attached.</p>
<p>Thanks Thomas for keeping a close watch to the patch.</p>
<p>Cheers,</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35312007-08-16T00:26:00Zdillon
<ul></ul><p>It looks to me like this is ready enough to be committed to widen the<br /> testing arena. Mr Ritter, do you think its good enough to go into the<br /> tree? We can always apply more patches as they come in.</p>
<pre><code>I'm sorry I can't test it myself, I'm overloaded with work at the moment.</code></pre>
<pre><code>-Matt</code></pre> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35352007-08-16T03:32:01Zbaptiste.ritter
<ul></ul><p>For me (and my colleagues Jonathan and Nicolas) the patch is good enough to be committed ;<br />Furthermore, we think that by committing the patch we should have more feedbacks.</p>
<p>And if there is a bug discovered, we are here for assuring the support and correct it.</p>
<p>Regards,</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35362007-08-16T03:32:40Zthomas.nikolajsen
<ul></ul><p>I have done some CARP testing; it worked as expected.</p>
<p>Test was using 3 pc's on LAN (2 CARP enabled & one observer (ping))<br />(I guess vkernels sould be just as good :).</p>
<p>Regarding carp(4) SYNOPSIS: I think this should include 'options CARP'.<br />This is used in VKERNEL & LINT<br />(my initial problem was that kernel didn't link w/o this).</p>
<p>It would be nice to have CARP GENERIC;<br />this not done in patch, but it is included in VKERNEL.</p>
<p>Thanks for porting this nice feature.</p>
<pre><code>-thomas</code></pre> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35372007-08-16T03:54:00Zbastyaelvtars
<ul></ul><p>On Wed, 15 Aug 2007 20:32:41 -0000<br />Thomas Nikolajsen <<a class="email" href="mailto:sinknull@crater.dragonflybsd.org">sinknull@crater.dragonflybsd.org</a>> wrote:</p>
<p>That's my fault: I have patched with the older diff. The new one has<br />this fixed.</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35382007-08-16T04:31:00Zdillon
<ul></ul><p>:For me (and my colleagues Jonathan and Nicolas) the patch is good enough to be committed ;<br />:Furthermore, we think that by committing the patch we should have more feedbacks.<br />:<br />:And if there is a bug discovered, we are here for assuring the support and correct it.<br />:<br />:Regards,<br />:<br />:-- <br />:Baptiste Ritter</p>
<pre><code>I've got it all ready to commit. I need to what attribution to put in<br /> the commit message though.</code></pre>
<pre><code>Submitted-by: Baptiste Ritter &lt;<a class="email" href="mailto:baptiste.ritter@ulp.u-strasbg.fr">baptiste.ritter@ulp.u-strasbg.fr</a>&gt;,<br /> Jonathan ?<br /> Nicolas ?</code></pre>
<pre><code>Reviewed-by: Thomas Nikolajsen<br /> Gergo Szakal &lt;<a class="email" href="mailto:bastyaelvtars@gmail.com">bastyaelvtars@gmail.com</a>&gt;</code></pre>
<pre><code>Obtained-from: OpenBSD, NetBSD, and FreeBSD</code></pre>
<pre><code>You can give me as little or as much information as you want on<br /> your collegues.</code></pre>
<pre><code>-Matt<br /> Matthew Dillon <br /> &lt;<a class="email" href="mailto:dillon@backplane.com">dillon@backplane.com</a>&gt;</code></pre> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35392007-08-16T04:35:01Zthomas.nikolajsen
<ul></ul><p>SYSOPSIS isn't including 'options CARP' in new patch in this issue.<br />Change between the two patches in this issue is just:<br />s/device carp/pseudo-device carp/</p>
<pre><code>-thomas</code></pre>
<p><a class="external" href="http://bugs.dragonflybsd.org/file329/carp-20070811BR01.patch">http://bugs.dragonflybsd.org/file329/carp-20070811BR01.patch</a><br />..<br /><ins>.Sh SYNOPSIS<br /></ins>.Cd "pseudo-device carp" <br />+.Sh DESCRIPTION<br />..</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35402007-08-16T04:38:01Zdillon
<ul></ul><p>:It would be nice to have CARP GENERIC;<br />:this not done in patch, but it is included in VKERNEL.<br />:<br />:Thanks for porting this nice feature.<br />:<br />: -thomas</p>
<pre><code>I'm going to hold off making it the default in GENERIC and VKERNEL<br /> until we can think that through a bit more.</code></pre>
<pre><code>Actually, you know what we <strong>REALLY</strong> need, we need a 'kernel' manual<br /> page which describes all the really cool options kernels can be built<br /> with in detail. LINT doesn't really do it justice.</code></pre>
<pre><code>-Matt<br /> Matthew Dillon <br /> &lt;<a class="email" href="mailto:dillon@backplane.com">dillon@backplane.com</a>&gt;</code></pre> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35412007-08-16T05:04:01ZTGEN
<ul></ul><p>Like options(4) on NetBSD?</p>
<p>Cheers,<br />-- <br /> Thomas E. Spanjaard<br /> <a class="email" href="mailto:tgen@netphreax.net">tgen@netphreax.net</a></p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35422007-08-16T05:08:00Zbastyaelvtars
<ul></ul><p>On Wed, 15 Aug 2007 14:26:48 -0700 (PDT)<br />Matthew Dillon <<a class="email" href="mailto:dillon@apollo.backplane.com">dillon@apollo.backplane.com</a>> wrote:</p>
<p>My role was testing. I cannot review this :-)</p> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35442007-08-17T22:59:02Zdillon
<ul></ul><p>Patch <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: K&R -> ANSI cleanup status (Closed)" href="https://bugs.dragonflybsd.org/issues/2">#2</a> has been committed! I do not have it set as the default<br /> for any kernels yet, though.</p>
<pre><code>-Matt</code></pre> DragonFlyBSD - Bug #664: Second patch for CARPhttps://bugs.dragonflybsd.org/issues/664?journal_id=35452007-08-18T17:55:01Zbaptiste.ritter
<ul></ul><p>Although I've seen that it is already commit, for information my colleagues were:<br />- Jonathan Buschmann <<a class="email" href="mailto:jonthn+dfly@agmact.com">jonthn+dfly@agmact.com</a>><br />- Nicolas Riss <<a class="email" href="mailto:nicolas.riss@dakot.net">nicolas.riss@dakot.net</a>></p>
<p>Cheers,</p>