Project

General

Profile

Actions

Bug #73

closed

outb|inb warnings patch

Added by slynko about 17 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hi,

this patch fix warnings produced by macros like outb (see the comment to
outb macro in sys/i386/include/cpufunc.h)


Files

clock.outb.diff (605 Bytes) clock.outb.diff slynko, 01/18/2006 05:59 PM
spic.outb.diff (566 Bytes) spic.outb.diff slynko, 01/18/2006 05:59 PM
Actions #1

Updated by joerg about 17 years ago

On Wed, Jan 18, 2006 at 08:52:27PM +0300, Alexey Slynko wrote:

Hi,

this patch fix warnings produced by macros like outb (see the comment to
outb macro in sys/i386/include/cpufunc.h)

Please don't do this, this warnings are a good reminder that the code is
archaic and MUST be converted to newbus. Beside that is this fix
incorrect since ports are 16bit integers, aka shorts. The choosen type
is perfectly valid.

Joerg

Actions #2

Updated by qhwt+dfly over 16 years ago

On Wed, Jan 18, 2006 at 08:55:14PM +0100, wrote:

Please don't do this, this warnings are a good reminder that the code is
archaic and MUST be converted to newbus.

So, is anyone working on converting them to newbus? :)

Actions #3

Updated by swildner over 10 years ago

  • File deleted (if_sr.outb.diff)
Actions #4

Updated by swildner over 10 years ago

  • File deleted (if_rdp.outb.diff)
Actions #5

Updated by swildner over 10 years ago

  • File deleted (if_ie.outb.diff)
Actions #6

Updated by swildner over 10 years ago

  • File deleted (cronyx.outb.diff)
Actions #7

Updated by tuxillo almost 10 years ago

  • Description updated (diff)
  • Status changed from New to Feedback
  • Assignee deleted (0)

Hi,

Does somebody have more information on this 'newbus conversion' stuff?
If so, either update this ticket or add it to the 'Projects page' and close this ticket.

Best regards,
Antonio Huete

Actions #8

Updated by swildner almost 10 years ago

  • Status changed from Feedback to Closed

There are no warnings anymore in the files affected by the two leftover patches (the rest were already removed some months ago). I guess this is due to compiler differences (GCC 4.4 and 4.7 both seem to get along fine with the current code).

Actions

Also available in: Atom PDF