https://bugs.dragonflybsd.org/
https://bugs.dragonflybsd.org/favicon.ico?1629395208
2007-08-24T23:07:00Z
DragonFlyBSD bugtracker
DragonFlyBSD - Bug #789: (part 2) pppX fix for altq/pf
https://bugs.dragonflybsd.org/issues/789?journal_id=3565
2007-08-24T23:07:00Z
dillon
<ul></ul><p>:Oops, this is also needed!</p>
<pre><code>p.s. all these patches are malformed. Your mailer is doing something<br /> bad to them. Don't repost, I'm patching it manually. But just to let<br /> you know.</code></pre>
<pre><code>-Matt</code></pre>
<p>:<br />:Index: ppp_tty.c<br />:===================================================================<br />:RCS file: /usr/dfly/repo/src/sys/net/ppp_layer/ppp_tty.c,v<br />:retrieving revision 1.23<br />:diff <del>u -r1.23 ppp_tty.c<br />:--</del> ppp_tty.c 22 Dec 2006 23:44:57 <del>0000 1.23<br />:+++ ppp_tty.c 11 Apr 2007 03:41:54 -0000<br />:<code>@ -378,12 +368,16 </code>@<br />: uio</del>>uio_resid < PPP_HDRLEN)<br />: return (EMSGSIZE);<br />:<br />: crit_enter();<br />: for (mp = &m0; uio->uio_resid; mp = &m->m_next) {<br />:- <abbr title="m, MB_WAIT, MT_DATA">MGET</abbr>;<br />:+ if ( mp == &m0 ) {<br />:+ <abbr title="m, MB_WAIT, MT_DATA">MGETHDR</abbr>;<br />:+ m->m_pkthdr.len = uio->uio_resid - PPP_HDRLEN;<br />:+ m->m_pkthdr.rcvif = NULL;<br />:+ }<br />:+ else<br />:+ <abbr title="m, MB_WAIT, MT_DATA">MGET</abbr>;<br />: if ((*mp = m) == NULL) {<br />: m_freem(m0);<br />:- crit_exit();<br />: return (ENOBUFS);<br />: }<br />: m->m_len = 0;<br />:</p>
<pre><code>Matthew Dillon <br /> &lt;<a class="email" href="mailto:dillon@backplane.com">dillon@backplane.com</a>&gt;</code></pre>
DragonFlyBSD - Bug #789: (part 2) pppX fix for altq/pf
https://bugs.dragonflybsd.org/issues/789?journal_id=3566
2007-08-24T23:09:01Z
dillon
<ul></ul><p>:Oops, this is also needed!<br />:<br />: crit_enter();<br />: for (mp = &m0; uio->uio_resid; mp = &m->m_next) {<br />:- <abbr title="m, MB_WAIT, MT_DATA">MGET</abbr>;<br />:+ if ( mp == &m0 ) {<br />:+ <abbr title="m, MB_WAIT, MT_DATA">MGETHDR</abbr>;<br />:+ m->m_pkthdr.len = uio->uio_resid - PPP_HDRLEN;<br />:+ m->m_pkthdr.rcvif = NULL;<br />:+ }<br />:+ else<br />:+ <abbr title="m, MB_WAIT, MT_DATA">MGET</abbr>;<br />: if ((*mp = m) == NULL) {<br />: m_freem(m0);<br />:- crit_exit();</p>
<pre><code>I think that crit_exit() has to stay.</code></pre>
<pre><code>-Matt</code></pre>
DragonFlyBSD - Bug #789: (part 2) pppX fix for altq/pf
https://bugs.dragonflybsd.org/issues/789?journal_id=3591
2007-08-28T00:21:33Z
hasso
<ul></ul><p><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: CORRECTION: (part 2) pppX fix for altq/pf (Closed)" href="https://bugs.dragonflybsd.org/issues/788">#788</a> contains correct fix.</p>