Project

General

Profile

Bug #2509

Updated by tuxillo 6 months ago

I noticed that sbin/restore/interactive.c includes both <dirent.h> and <vfs/ufs/dir.h>, both of which define DIRBLKSIZ, but to different values. 

 

 In _<dirent.h>_ : 

 @#define <dirent.h>: 

 #define DIRBLKSIZ         1024@ 

 1024 

 In _<vfs/ufs/dir.h>_ : 

 @#define <vfs/ufs/dir.h>: 

 #define DIRBLKSIZ         DEV_BSIZE@ 

 DEV_BSIZE 

 It seems to be a poor choice of names and ends up being 512 just by the ordering of includes in interactive.c. 

 

 Venkatesh told me to file a bug (so he doesn't forget), which I hereby did. 
 

Back