Bug #1549

hammer mirror-copy from old hammer version to new hammer version screws up completely

Added by corecode about 5 years ago. Updated over 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

When performing a mirror-copy from an old hammer version to a new
version, no directory contents appear. the pfs is basically unusable,
yet uses up disk space.

THIS IS EXTREMELY ANNOYING AND DANGEROUS. WHY IS THIS STILL NOT FIXED?

This is a great opportunity to completely destroy all your data. EXCELLENT!

History

#1 Updated by dillon about 5 years ago

:
:When performing a mirror-copy from an old hammer version to a new
:version, no directory contents appear. the pfs is basically unusable,
:yet uses up disk space.
:
:THIS IS EXTREMELY ANNOYING AND DANGEROUS. WHY IS THIS STILL NOT FIXED?
:
:This is a great opportunity to completely destroy all your data. EXCELLENT!

Well, this is the first time I've heard of this. A mirror-copy
from an old hammer to a new one should work fine in theory. Are you
sure you weren't copying the other way around? Copying a new hammer
to an old hammer would not work.

Was it a clean mirror-copy or did you forcefully downgrade a master
into a slave first?

-Matt
Matthew Dillon
<>

#2 Updated by corecode about 5 years ago

Matthew Dillon wrote:
> :
> :When performing a mirror-copy from an old hammer version to a new
> :version, no directory contents appear. the pfs is basically unusable,
> :yet uses up disk space.
> :
> :THIS IS EXTREMELY ANNOYING AND DANGEROUS. WHY IS THIS STILL NOT FIXED?
> :
> :This is a great opportunity to completely destroy all your data. EXCELLENT!
>
> Well, this is the first time I've heard of this. A mirror-copy
> from an old hammer to a new one should work fine in theory. Are you
> sure you weren't copying the other way around? Copying a new hammer
> to an old hammer would not work.

It was certainly from old to new. This happened before and I reported
on IRC, but considered it as an error on my part. Now it happening
again means that something is really wrong.

> Was it a clean mirror-copy or did you forcefully downgrade a master
> into a slave first?

Clean hammer mirror-copy /path/to/old-pfs /path/to/nonexisting-new-pfs

cheers
simon

#3 Updated by dillon about 5 years ago

:
:Matthew Dillon wrote:
:> :
:> :When performing a mirror-copy from an old hammer version to a new
:> :version, no directory contents appear. the pfs is basically unusable,
:> :yet uses up disk space.
:> :
:> :THIS IS EXTREMELY ANNOYING AND DANGEROUS. WHY IS THIS STILL NOT FIXED?
:> :
:> :This is a great opportunity to completely destroy all your data. EXCELLENT!
:>
:> Well, this is the first time I've heard of this. A mirror-copy
:> from an old hammer to a new one should work fine in theory. Are you
:> sure you weren't copying the other way around? Copying a new hammer
:> to an old hammer would not work.
:
:It was certainly from old to new. This happened before and I reported
:on IRC, but considered it as an error on my part. Now it happening
:again means that something is really wrong.
:
:> Was it a clean mirror-copy or did you forcefully downgrade a master
:> into a slave first?
:
:Clean hammer mirror-copy /path/to/old-pfs /path/to/nonexisting-new-pfs
:
:cheers
: simon

Ok, it is definitely a bug. The HAMMER code is creating a root inode
for the slave PFS, which causes it to ignore the root inode it would
otherwise copy from the master. This combined with the directory
capabilities being different between version 1 and version 2 is
breaking the root directory.

I have committed fixes to both master and DragonFly_RELEASE_2_4.
Any newly created slave PFSs should work as expect when doing a
mirror-copy from an older HAMMER filesystem to a newer one.

-Matt
Matthew Dillon
<>

#4 Updated by thomas.nikolajsen over 4 years ago

Fixed in commit 9a032a4a6043b9cbd16e28fa42266da57a854b40

Also available in: Atom PDF