Project

General

Profile

Actions

Bug #2990

closed

sys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition

Added by dcb over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
03/28/2017
Due date:
% Done:

0%

Estimated time:

Description

dragonfly/sys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

if ((status = bs->AllocatePool(EfiLoaderData, hsize,
(void **)&handles) != EFI_SUCCESS)) {

Maybe better code

if ((status = bs->AllocatePool(EfiLoaderData, hsize,
(void **)&handles)) != EFI_SUCCESS) {
Actions #1

Updated by dillon over 7 years ago

  • Status changed from New to Closed

fix committed to master

Actions

Also available in: Atom PDF