Actions
Bug #2990
closedsys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
03/28/2017
Due date:
% Done:
0%
Estimated time:
Description
dragonfly/sys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
if ((status = bs->AllocatePool(EfiLoaderData, hsize,
(void **)&handles) != EFI_SUCCESS)) {
Maybe better code
if ((status = bs->AllocatePool(EfiLoaderData, hsize,
(void **)&handles)) != EFI_SUCCESS) {
Actions