Bug #310

can't handle dangerously dedicated (no slices) mode

Added by corecode almost 8 years ago. Updated almost 8 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

hey,

I tried booting in qemu with an image which doesn't have a slice table, but directly a disklabel, and I get this:

ad0s4: type 0xa5, start 0, end = 49999, size 50000
ad0s4: C/H/S end 1023/254/63 (16450559) != end 49999: invalid
ad0: raw partition size != slice size
ad0: start 0, end 49999, size 50000
ad0c: start 0, end 2097151, size 2097152
ad0: truncating raw partition
ad0: rejecting partition in BSD label: it isn't entirely within the slice
ad0: start 0, end 49999, size 50000
ad0a: start 0, end 2097151, size 2097152
Root mount failed: 22

Before I also experienced something like that with vn0, but somehow it vanished...

I would say that isn't expected.

cheers
simon

diskmbr-dd.diff Magnifier (3.34 KB) TGEN, 11/25/2006 08:09 PM

History

#1 Updated by TGEN almost 8 years ago

Simon 'corecode' Schubert wrote:
> I tried booting in qemu with an image which doesn't have a slice table,

I have one 'sliceless' disk as well, though not a root mount. No
problems here, though this is 1.3-Preview.
/dev/ad6a 4.9G 645M 3.9G 14% /ex
/dev/ad6d 224G 155G 52G 75% /stor

Cheers,
--
Thomas E. Spanjaard

#2 Updated by TGEN almost 8 years ago

Attached is a patch which fixes proper detection of the 'new'
Dangerously Dedicated MBR. Our boot1 and disklabel already supported it,
but our disk mbr handling code didn't.

Cheers,
--
Thomas E. Spanjaard

#3 Updated by dillon almost 8 years ago

:Attached is a patch which fixes proper detection of the 'new'
:Dangerously Dedicated MBR. Our boot1 and disklabel already supported it,
:but our disk mbr handling code didn't.
:
:Cheers,
:--
: Thomas E. Spanjaard
:

Committed!

-Matt

#4 Updated by TGEN almost 8 years ago

Patch has been committed.

Also available in: Atom PDF