Actions
Bug #3103
closedsys/dev/video/bktr/bktr_core.c: 3 * poor error checking ?
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
11/15/2017
Due date:
% Done:
0%
Estimated time:
Description
1.
dragonfly/sys/dev/video/bktr/bktr_core.c:1845]: (style) Checking if unsigned variable 'temp' is less than zero.
temp = tv_channel( bktr, (int)*(unsigned long *)arg );
if ( temp < 0 ) {
but
unsigned int temp, temp1;
and
dragonfly/sys/dev/video/bktr/bktr_tuner.h:int tv_channel( bktr_ptr_t bktr, int channel );
2.
dragonfly/sys/dev/video/bktr/bktr_core.c:1887]: (style) Checking if unsigned variable 'temp' is less than zero.
3.
dragonfly/sys/dev/video/bktr/bktr_core.c:2171]: (style) Checking if unsigned variable 'temp' is less than zero.
Duplicates.
Updated by swildner over 6 years ago
- Status changed from New to Closed
I've pushed a fix to master.
Thanks for pointing out.
Actions