Project

General

Profile

Actions
Copy link

Bug #3108

closed

sys/dev/disk/fd/fd.c:802: suspicious if statement ?

Added by dcb about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Driver
Target version:
-
Start date:
12/04/2017
Due date:
% Done:

0%

Estimated time:

Description

dragonfly/sys/dev/disk/fd/fd.c:799] -> [dragonfly/sys/dev/disk/fd/fd.c:802]: (warning) Opposite inner 'if' condition leads to a dead code block.

Source code is

error = isa_dma_acquire(fdc->dmachan);
        if (!error) {
            isa_dma_init(fdc->dmachan, 128 << 3 /* XXX max secsize */,
                     M_WAITOK);
            if (error) {
                isa_dma_release(fdc->dmachan);
Actions
Copy link
 #1

Updated by zrj about 7 years ago

  • Status changed from New to Closed

zrj puts a pointy hat.

Thanks for reporting it, fixed in a8a4cdd.

Actions
Copy link

Also available in: Atom PDF