Project

General

Profile

Actions

Submit #3138

closed

Use NULL instead of zero in chown.c

Added by thomas.barabosch almost 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
06/14/2018
Due date:
% Done:

0%

Estimated time:

Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
 
Hi,

this is a small fix to chown.c. The call to fts_open should use NULL as
third argument instead of zero. This documents the intent, though it is
a matter of aesthetics. I saw this zero/NULL pointer "problem" a couple
of times, though I can't remember where exactly. Consider this as a
start. May be we should grep for this in the future.

Please find attached a trivial patch.

Best regards,

Thomas

- --
Thomas Barabosch

Fraunhofer FKIE                        Tel.:   +49 228 50212-601
Cyber Analysis & Defense               Fax:    +49 228 73-4571
Zanderstraße 5                         D-53113 Bonn, Germany  
http://www.fkie.fraunhofer.de/
-----BEGIN PGP SIGNATURE-----
 
iQIzBAEBCAAdFiEEe1xcQ2pbVpNHovi8uwR0RNbF+7IFAlsiazAACgkQuwR0RNbF
+7K3JA/+PhdzFPN5vVdHNywFeL1VfhlD3C2iQ5T0lA7BAkmQXEvTs5vfZwB76Bhg
3JgKwaRXj2iYhe03hnd7wG3qX/qP+fTSBDLMwiMxT5pEc3HaNydlE9CGTPtFDYOO
foYQfQEh27Zh9gAV4fNeuMDX+QyR8pi9lZhIPyG6MLCxo93CpFAaF2CN07niNPjP
QzTcNR/X+fjKqh3f7CSIp2EM4HaGdfPrN5t/jcR+SXKlsCNCPEdbQMgMnQP2/0IW
Je4aaS+B2uRvKXAuB4Qwol9KiW70D7nNNCyfk7sLk3ntmkORpg+NkNJdPkbxx5NV
dFUEAraBO7pA2+z5lHfhMgLFbMAbTi0t7sX+plaHUtFsWdP3VzFZ1D+vjo485pDT
5ubI8s/nlw6Ff5FvK0grs8BVnjeIvVjTvY9N6MnFo7PBfAi/UquIoMMd9lv8BRQE
hYJXKT3q0oOWLkfVrtAkA6m3fJdnrJ+BuR6TRzTbA7/9cKzTqIXR8Bz9RtzpRaKt
k7SwEMKtS8Ep9pvN0LmXsXzbhaVW7ptbL5CLhrdi6D1fCCPOpFdtx/NLBzzZ7TcV
ue1rGOG6zBMxSEQdMt2GX7rfD+wkg6B3cQbz7WOlx04s0pxSMRP0yEDQrwvxYasY
VJ0zs966SgV5A/dKIckl7IWnmemYaHMndHsteV021tDPvKiMgT0=
=Z4jP
-----END PGP SIGNATURE-----


Files

chown.c.patch (417 Bytes) chown.c.patch thomas.barabosch, 06/14/2018 06:20 AM
chown.c.patch.sig (566 Bytes) chown.c.patch.sig thomas.barabosch, 06/14/2018 06:20 AM
Actions #1

Updated by liweitianux almost 5 years ago

  • Status changed from New to Closed

Thank you for the patch. I've incorporated your patch and expanded it to adjust fts_open() in chmod(1), chflags(1) and chown(8).

Regards,
Aly

Actions

Also available in: Atom PDF