DragonFlyBSD

You can rip this `#ifndef CPUID2_EST' part completely, because CPU
feature bits won't change after the machine booted. The code was
only there because I didn't want to mess with identcpu.c :)

Will do. What do you think about the <sys/systm.h> containing MD
definitions?

Cheers,
--
Thomas E. Spanjaard
tgen@netphreax.net

It's been moved from <machine/md_var.h> by this commit:
http://leaf.dragonflybsd.org/mailarchive/commits/2006-11/msg00027.html

The current users of cpu_feature outside /sys/{cpu,machine} are:
emulation/linux/i386/linprocfs/linprocfs_misc.c
kern/kern_ktr.c
net/altq/altq_subr.c
the last two files use it to deal with TSC register, which is also
specific to CPU. I guess that this is the reason cpu_feature has been
moved into <sys/systm.h> (but you should ask Matt, of course).

It looks OK to me to move it into cpufunc.h; my only question is
what the name(s) of CPU name is for vkernel, if we're to move to
<machine/cpufunc.h>.

Cheers.

Hmm. Imho, it should remain under machine/, perhaps with an include in
sys/systm.h.

You mean MI code has special handling of the x86 TSC? There ought to be
a better way...

I'm not yet positive of where it really should end up, none of the
cpu*.h files, nor specialreg.h seem entirely appropriate. But I'll
commit the original patch with the removing of the logic in est.c in 24
hours, leaving this for another time.

Cheers,
--
Thomas E. Spanjaard
tgen@netphreax.net