Bug #876
closedclarify description for LWP_WSTOP
0%
Description
Inspired by the fix for issue 761
(http://bugs.dragonflybsd.org/issue761).
Discussed-with: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Index: sys/sys/proc.h
===================================================================
retrieving revision 1.114
diff u -r1.114 proc.h sys/sys/proc.h
--
+++ sys/sys/proc.h@ -37,7 +37,7
@
*
* @(#)proc.h 8.15 (Berkeley) 5/19/95
* $FreeBSD: src/sys/sys/proc.h,v 1.99.2.9 2003/06/06 20:21:32 tegge Exp $
- * $DragonFly: src/sys/sys/proc.h,v 1.114 2007-08-30 20:41:00 pavalos Exp $
+ * $DragonFly: src/sys/sys/proc.h,v 1.114 2007/08/30 20:41:00 pavalos Exp $
*/
#ifndef SYS_PROC_H
@ -363,7 +363,7
@
#define LWP_SELECT 0x0000010 /* Selecting; wakeup/waiting danger. /
#define LWP_ONRUNQ 0x0000020 / on a user scheduling run queue /
#define LWP_WEXIT 0x0000040 / working on exiting /
-#define LWP_WSTOP 0x0000080 / working on stopping /
+#define LWP_WSTOP 0x0000080 / has been counted in the process stopped-threads-count */
#define FIRST_LWP_IN_PROC(p) RB_FIRST(lwp_rb_tree, &(p)->p_lwp_tree)
#define FOREACH_LWP_IN_PROC(lp, p) \
Updated by aoiko over 16 years ago
On Thursday 06 December 2007, Aggelos Economopoulos wrote:
There are a lot of other offenders in proc.h, but this line is way above
80 columns. Shorter version follows.
Index: sys/sys/proc.h
===================================================================
retrieving revision 1.114
diff u -r1.114 proc.h sys/sys/proc.h
--
+++ sys/sys/proc.h@ -37,7 +37,7
@
*
* @(#)proc.h 8.15 (Berkeley) 5/19/95
* $FreeBSD: src/sys/sys/proc.h,v 1.99.2.9 2003/06/06 20:21:32 tegge Exp $
- * $DragonFly: src/sys/sys/proc.h,v 1.114 2007-08-30 20:41:00 pavalos Exp $
+ * $DragonFly: src/sys/sys/proc.h,v 1.114 2007/08/30 20:41:00 pavalos Exp $
*/
#ifndef SYS_PROC_H
@ -363,7 +363,7
@
#define LWP_SELECT 0x0000010 /* Selecting; wakeup/waiting danger. /
#define LWP_ONRUNQ 0x0000020 / on a user scheduling run queue /
#define LWP_WEXIT 0x0000040 / working on exiting /
-#define LWP_WSTOP 0x0000080 / working on stopping /
+#define LWP_WSTOP 0x0000080 / has been counted in p_nstopped */
#define FIRST_LWP_IN_PROC(p) RB_FIRST(lwp_rb_tree, &(p)->p_lwp_tree)
#define FOREACH_LWP_IN_PROC(lp, p) \
Updated by dillon over 16 years ago
:Discussed-with: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
:
:...
: #define LWP_ONRUNQ 0x0000020 /* on a user scheduling run queue /
: #define LWP_WEXIT 0x0000040 / working on exiting /
:-#define LWP_WSTOP 0x0000080 / working on stopping /
:+#define LWP_WSTOP 0x0000080 / has been counted in the process stopped-threads-count */
I will add a more involved comment.
-Matt
Matthew Dillon
<dillon@backplane.com>