Project

General

Profile

Actions

Bug #1001

closed

spinlock random exponential backoff

Added by sepherosa over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hi,

I have problem under specific test case, if I use spinlock on ifq (got
many "indefinite wait" logging). With following patch things improve
greatly, there is almost no "indefinite wait"!. Please review it:
http://leaf.dragonflybsd.org/~sephe/kern_spinlock.c.diff1

Best Regards,
sephe

Actions #1

Updated by dillon over 13 years ago

:Hi,
:
:I have problem under specific test case, if I use spinlock on ifq (got
:many "indefinite wait" logging). With following patch things improve
:greatly, there is almost no "indefinite wait"!. Please review it:
:http://leaf.dragonflybsd.org/~sephe/kern_spinlock.c.diff1
:
:Best Regards,
:sephe

Looks good.  We might want to also change that cpu_nop() into a
cpu_pause(), or perhaps even call both.
-Matt
Matthew Dillon
<>
Actions #2

Updated by sepherosa over 13 years ago

committed

Actions

Also available in: Atom PDF