Project

General

Profile

Actions

Bug #1606

closed

hack(6): fix old mis-merge

Added by uqs about 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

hack(6): fix very old mis-merge by restoring code from OpenBSD

If you look at the CVS history for this file, you will see that
the code in question tried to find the provided name in the path, not
just a fixed location (that could be coded more easily).

Restore the OpenBSD version of this code, which was cleaned up, already


Files

hack.diff (1.89 KB) hack.diff uqs, 11/15/2009 05:21 PM
Actions #2

Updated by dillon about 15 years ago

:Ulrich Spoerlein <> added the comment:
:
:See=20
:http://gitweb.dragonflybsd.org/~uqs/games.git/commit/c91833b608a45e8bca8bd9=
:85725ce3bfa716466a
:
:hth
:
:----------
:status: unread -> chatting

This is going to wind up finding /usr/games/hack instead of 
/usr/games/hide/hack, however, when we want it to find
/usr/games/hide/hack. /usr/games/hide is not in the path.
The only use case is to locate the actual game binary
and stat it to determine if the saved game is out of date
relative to the binary.
-Matt
Matthew Dillon
&lt;&gt;
Actions #3

Updated by uqs about 15 years ago

Good catch Matt,

thing is that I want to remove dm(6) altogether, just like OpenBSD did. The
patch worked for FreeBSD as no dm(6) is used there either.

I will come up with a better solution.

Actions #4

Updated by tuxillo over 14 years ago

Hi,

Any update on this?

Cheers,
Antonio Huete

Actions #5

Updated by uqs over 14 years ago

When/If I get around to finishing the NetBSD/OpenBSD sync, I will revisit. This
issue can be closed for now, as it doesn't apply.

Actions

Also available in: Atom PDF