Bug #268
closed
Extraneous assignment in rev(1)
0%
Description
This was noticed in openbsd by bret.lambert at gmail.com, but it looks
like DragonFly uses the same code.
Index: usr.bin/rev/rev.c
===================================================================
RCS file: /home/dcvs/src/usr.bin/rev/rev.c,v
retrieving revision 1.6
diff u -r1.6 rev.c usr.bin/rev/rev.c 14 Dec 2004 18:22:09
--0000 1.6 t = p + len - 1;
+++ usr.bin/rev/rev.c 4 Jul 2006 21:48:05 -0000@ -95,7 +95,6 @
while ((p = fgetln(fp, &len)) != NULL) {
if (p[len - 1] == '\n')
--len;
for (t = p + len - 1; t >= p; --t)
putchar(*t);
putchar('\n');
Updated by dillon over 18 years ago
:This was noticed in openbsd by bret.lambert at gmail.com, but it looks
:like DragonFly uses the same code.
:
:Index: usr.bin/rev/rev.c
:===================================================================
:RCS file: /home/dcvs/src/usr.bin/rev/rev.c,v
:retrieving revision 1.6
:diff u -r1.6 rev.c usr.bin/rev/rev.c 14 Dec 2004 18:22:09
:--0000 1.6 t = p + len - 1;
:+++ usr.bin/rev/rev.c 4 Jul 2006 21:48:05 -0000
:@ -95,7 +95,6 @
: while ((p = fgetln(fp, &len)) != NULL) {
: if (p[len - 1] == '\n')
: --len;
:
: for (t = p + len - 1; t >= p; --t)
: putchar(*t);
: putchar('\n');
Heh. Ok, fixed.-Matt
Matthew Dillon
<dillon@backplane.com>