Project

General

Profile

Actions
Copy link

Bug #2991

closed

sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition

Added by dcb about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
03/28/2017
Due date:
% Done:

0%

Estimated time:

Description

sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

if ((error = age_dma_alloc(sc) != 0))
        goto fail;

Maybe better code

if ((error = age_dma_alloc(sc)) != 0)
        goto fail;
Actions
Copy link
 #1

Updated by dcb about 7 years ago

Same thing in different file:

dragonfly/sys/dev/netif/ale/if_ale.c:599]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Actions
Copy link
 #2

Updated by dillon about 7 years ago

  • Status changed from New to Closed

fix committed to master

Actions
Copy link
 #3

Updated by swildner about 7 years ago

I've pushed the ale(4) change too.

Actions
Copy link

Also available in: Atom PDF