Actions
Bug #2992
closed
sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
03/28/2017
Due date:
% Done:
0%
Estimated time:
Description
sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
if ((error = ((*type->constructor)(*nodepp)) != 0)) {maybe better code
if ((error = ((*type->constructor)(*nodepp))) != 0) {
Updated by
Actions