Project

General

Profile

Actions

Bug #3027

closed

installer: password do not allow special characters

Added by liweitianux almost 7 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
installer
Target version:
Start date:
04/14/2017
Due date:
% Done:

100%

Estimated time:

Description

Yesterday I tried install DFly (4.8.0-release) within VirtualBox, and found that the installer do NOT allow special characters (":;,`~!@#$%^&*()+={}[]\\|/?<>'\" ") in the password field. See also the attached screenshots.

On the other hand, I can set password with special characters using the "passwd" command after installation. In addition, the installer allow special characters in the passphrase for disk encryption.

The corresponding source code is "usr.sbin/installer/dfuibe_installer/fn_configure.c" line 85:
#define PW_NOT_ALLOWED ":;,`~!@#$%^&*()+={}[]\\|/?<>'\" "

Why place such a constrain on the user/root password?


Files

dfly_4.8_password.png (7.08 KB) dfly_4.8_password.png screenshots for password not allow special char liweitianux, 04/13/2017 11:09 PM
0001-Installer-allow-special-characters-in-passwords.patch (5.71 KB) 0001-Installer-allow-special-characters-in-passwords.patch piecuch, 04/13/2020 09:12 AM
Actions #1

Updated by liweitianux over 4 years ago

  • Category changed from Other to installer
  • Priority changed from High to Normal

Related issue: #2316

Actions #2

Updated by piecuch almost 4 years ago

  • File 0001-Installer-allow-special-characters-in-passwords.patch added
  • Status changed from New to Feedback
  • Target version set to 13

Fixed. Please see my patch.

Actions #3

Updated by piecuch almost 4 years ago

  • File deleted (0001-Installer-allow-special-characters-in-passwords.patch)
Actions #5

Updated by liweitianux almost 4 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

I committed a fix based on your patch in df29799be511167585aaaa3250904e87e4b54c4c. Thank you very much.

Actions

Also available in: Atom PDF