Project

General

Profile

Actions
Copy link

Bug #3060

closed

sys/boot/common/module.c:247: logical fault ?

Added by dcb over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
09/18/2017
Due date:
% Done:

0%

Estimated time:

Description

dragonfly/sys/boot/common/module.c:247] -> [dragonfly/sys/boot/common/module.c:254]: (warning) Identical condition 'got==0', second condition is always false

Source code is

got = read(fd, buf, 8192);
                if (got  0)
                        break;
                if (got < 0) {
                        printf("error reading '%s': %s\n",
                                name, strerror(errno));
                        break;
                }
                if (got  0)
                        crc = iscsi_crc32(buf, got);
                else
                        crc = iscsi_crc32_ext(buf, got, crc);

So it looks like the crc code is never executed.

Actions
Copy link

Also available in: Atom PDF