Project

General

Profile

Actions
Copy link

Bug #3102

closed

sys/dev/drm/radeon/radeon_uvd.c:897: possible cut'n'paste issue ?

Added by dcb about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Kernel
Target version:
-
Start date:
11/15/2017
Due date:
% Done:

0%

Estimated time:

Description

dragonfly/sys/dev/drm/radeon/radeon_uvd.c:897] -> [dragonfly/sys/dev/drm/radeon/radeon_uvd.c:903]: (warning) Identical condition 'vclk_div>pd_max', second condition is always false

Source code is

if (vclk_div > pd_max)
            break; /* vco is too big, it has to stop */
/* calc dclk divider with current vco freq /
        dclk_div = radeon_uvd_calc_upll_post_div(vco_freq, dclk,
                             pd_min, pd_even);
        if (vclk_div > pd_max)
            break; / vco is too big, it has to stop */

Maybe the 2nd if would be better if it sanity checked dclk_div, like

if (dclk_div > pd_max)
            break; /* vco is too big, it has to stop */
Actions
Copy link

Also available in: Atom PDF