Project

General

Profile

Actions
Copy link

Submit #3172

closed

Made some minimal smbfs changes from FreeBSD

Added by dragonpoet about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
dillon
Category:
-
Target version:
-
Start date:
02/12/2019
Due date:
% Done:

0%

Estimated time:

Description

Hi,

This is Varun writing from India. I'd very good experience in developing system level applications using C/C++. My bugs.dragonflybsd.com account name is dragonpoet.

I'm very much exited about DragonFlyBSD and would like to contribute for the same. As a first step I'd gone through the list of projects available here : https://www.dragonflybsd.org/docs/developer/ProjectsPage/#index2h3 and found out project "Bring in smbfs changes from FreeBSD (GCI:Code)" interesting. The attached patch file contains very basic and minimal changes which i'd found out to be important from latest FreeBSD source base for smbfs.
Please review and let me know if the changes are acceptable.

I'd tried the steps mentioned in the "Working with branches" section available here "https://www.dragonflybsd.org/docs/developer/TypicalGitUsage/" to push my changes. However, it looks like i don't have sufficient permission for doing the same since i'm getting the error "fatal: remote error: access denied or repository not exported: /dragonfly.git".

Could you please let me know how to get permissions for the same in a step by step way?

Regards,

Varun C H

Sent from [ProtonMail](https://protonmail.ch), encrypted email based in Switzerland.

Files

0001-Updated-spelling-corrections-as-well-as-safe-string-.patch (4.33 KB) 0001-Updated-spelling-corrections-as-well-as-safe-string-.patch dragonpoet, 02/12/2019 02:31 AM
Actions
Copy link
 #1

Updated by liweitianux about 5 years ago

Hi Varun,

Thank you for submitting the patch.

Only DragonFly committers can push to the official Git repo. I suggest that you fork the repo on Github (https://github.com/DragonFlyBSD/DragonFlyBSD ) and develop the patches on your feature-branch. When you finished, you can submit a Pull Request on the Github and update here to ask someone to review and handle it.

I also suggest you have a look at the development(7) man page (http://mdoc.su/d/development ).

Cheers,
Aaron

Actions
Copy link
 #2

Updated by dillon about 5 years ago

  • Status changed from New to Closed
  • Assignee set to dillon

I went ahead and applied the patch, since it was easy to do :-). Its in the master and release branch now.

Thanks for the submission!

-Matt

Actions
Copy link

Also available in: Atom PDF