Submit #3275
closed[PATCH] pw_scan: remove checks for (u|g)ids > USHRT_MAX.
0%
Description
Remove the check and simplify the logic for checking
UID/GID validity in `pw_scan()` by calling `strtonum`
instead of `strtoul`.
I ran into this because I use a non-default UID/GID
numbering scheme where both are typically greater
than 2^16 for normal users. The width of UIDs has
been 32 bits since before 4.4BSD in 1994, almost 27
years ago; if larger UIDs were going to show up as
a problem it would have already happened.
Files
Updated by dancrossnyc over 3 years ago
A gentle ping on this? I should note that FreeBSD effectively disabled this check in 2009: https://cgit.freebsd.org/src/commit/lib/libc/gen/pw_scan.c?id=764eca2591d4b1b0fdb45e4e839b1163bf76219f
Updated by liweitianux over 3 years ago
Hi. I've contacted Sascha Wildner to review and handle your patch. I think it will be merged soon.
Thank you for the help with this project :D
Cheers,
Aaron
Updated by swildner over 3 years ago
- Status changed from New to Closed
I've pushed it (with some minor adjustments in manual pages). Thanks!
https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/8f13a1c5481b54b10c81c0fb1c1f2b46f93cd643