Bug #909
closedssleep() (was Re: mention msleep() in porting_drivers.txt)
0%
Description
Now that I think about it, our msleep() is misnamed --- it should have
been called ssleep(). There's no "m" about it. Any objections to changing it?
Jeffrey
Updated by dillon almost 17 years ago
:Now that I think about it, our msleep() is misnamed --- it should have
:been called ssleep(). There's no "m" about it. Any objections to changing it?
:
: Jeffrey
If we're gonna start throwing around different types of sleeps maybe
we should make the names more verbose. spin_sleep(), lockmgr_sleep(),
etc. We don't use them so often that they'll clutter up the code and
the longer names will make the code more readable.
-Matt
Matthew Dillon
<dillon@backplane.com>
Updated by corecode almost 17 years ago
Could we please delay changing the name? There is a lot of work
happening and it is frustrating if you have to chase the code.
cheers
simon
Updated by tuxillo about 15 years ago
What was the final conclusion about this?
Renaming will happen or it will be dropped?
Updated by dillon about 15 years ago
I will revamp the *sleep() calls. Yes, at this point I think msleep() should
become ssleep() so msleep() can be used with mutex locks (mtx_t).
I will also change the serialize_sleep() calls to slzsleep(), since it looks
like we've given up on using longer names.
-Matt
Updated by tuxillo about 15 years ago
Renaming committed by Dillon.
e590ee86dda0f2b481981c8e73628e26c29e72d5