Project

General

Profile

Actions

Bug #1568

closed

[PATCH] etc/rc.d/initdiskless confusion regarding cpio archives

Added by rumcic about 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

"If /conf/<special_dir>/SUBDIR.cpio.gz exists, the file is cpio'd into the
specified /SUBDIR (and a memory filesystem is created for /SUBDIR if
necessary)."
.. but to unpack the archive it uses:
"(cd / ; /usr/bin/gzip -d < $j | /usr/bin/cpio --extract -d )"

Is it just me or is there a contradiction there? English is not my native
language , so I could be misunderstanding, but my interpretation of "the file
is cpio'd into the specified /SUBDIR" would be to cd into /SUBDIR and extract
the archive there.
Also checked freebsd's head and they have the same contradiction.

Since it's more in line with other stuff in initdiskless (like SUBDIR.remove
which removes files relative to SUBDIR), I'd prefer something like the
attached patch (also gzip is skipped in the attached patch since cpio itself
seems to be able to read the gzipped archive).
--
Regards,
Rumko


Files

initdiskless.patch (480 Bytes) initdiskless.patch rumcic, 10/13/2009 10:46 AM
Actions #1

Updated by josepht over 14 years ago

patch committed.

Actions

Also available in: Atom PDF