Submit #1192

KKASSERTs in sys/kern/uipc_{msg,socket}.c are too strict

Added by rumcic over 6 years ago. Updated 4 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Kernel
Target version:4.2.x

Description

The code for nfs root mounts does not use kmalloc-ed space for some vars, while
some KKASSERTs in the mentioned files only check for the supplied pointers if
they were kmalloc-ed or not.
The attached patch adds a check if the supplied pointers are not in user stack
(if they are in kernel stack) ... since kmalloc-ed space also resides in the
addresses not in user stack, maybe kva_p should be removed (is it used
anywhere else?)?
--
Regards,
Rumko

rootnfs.patch Magnifier (2.63 KB) rumcic, 12/29/2008 10:05 PM

History

#1 Updated by corecode over 6 years ago

has this been fixed?

#2 Updated by rumcic about 6 years ago

No, not yet. (Sorry for the late response)

#3 Updated by tuxillo 4 months ago

  • Tracker changed from Bug to Submit
  • Description updated (diff)
  • Category set to Kernel
  • Assignee deleted (alexh)
  • Priority changed from High to Normal
  • Target version set to 4.2.x

Hi,

Indeed, kva_p() is only used in uipc_msg.c and uipc_socket.c
Matt, what do you think about the attached patch?

Cheers,
Antonio Huete

Also available in: Atom PDF