DragonFlyBSD

Sure, I don't think you have to ask for permission. If you think the fix
needs to go in, it needs to go in :)

Is that a source of interrupt routing problems? Do you know when this bug
would happen and which effects it would have?

cheers
simon

On Wed, Feb 4, 2009 at 7:43 PM, Simon 'corecode' Schubert
<corecode@fs.ei.tum.de> wrote:
> Sepherosa Ziehau wrote:
>>
>> Hi all,
>>
>> I want following patch in 2.2 release (i.e. I need the permission to
>> push it to master):
>>
>> http://leaf.dragonflybsd.org/~sephe/0001-pci-intr-config-Fix-an-off-by-one-bug.patch
>>
>> Please review it.
>
> Sure, I don't think you have to ask for permission. If you think the fix
> needs to go in, it needs to go in :)
>
> Is that a source of interrupt routing problems? Do you know when this bug
> would happen and which effects it would have?

Can't say it will be root cause, however, it could cause potential problems.

Best Regards,
sephe

I don't even understand what that loop is doing :-) matchpin is
supposed to start at 1?

-Matt

On Thu, Feb 5, 2009 at 12:18 PM, Matthew Dillon
<dillon@apollo.backplane.com> wrote:
> I don't even understand what that loop is doing :-) matchpin is

It tries to find the device using the same pin and has been "correctly" routed.

Yep, it starts from 1.

Best Regards,
sephe

OK to "push"?

Here is another trivial fix:
http://leaf.dragonflybsd.org/~sephe/0001-pci-intr-config-j-is-the-pin-index-we-want-to-ski.patch

Please review it. I want to push the above patch too.

Best Regards,
sephe

:> Yep, it starts from 1.
:>
:
:OK to "push"?
:
:Here is another trivial fix:
:http://leaf.dragonflybsd.org/~sephe/0001-pci-intr-config-j-is-the-pin-index-we-want-to-ski.patch
:
:Please review it. I want to push the above patch too.
:
:Best Regards,
:sephe
:
:--
:Live Free or Die

Yah, push'm both.

-Matt
Matthew Dillon
<dillon@backplane.com>

committed