Bug #1700

skip boot2 menu on <enter>

Added by Johannes.Hofmann about 4 years ago. Updated over 3 years ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Hi,

tuxillo noticed that the trick to speedup booting by hitting <enter>
does not work with default UFS-based installations, as those have no
separate /boot partition, and therefore the default location for the
loader is wrong (it had been changed to match default HAMMER
installations in 3735e368a1bdbe773c79c34512f49c905ff77bd7)

We could change boot2 to just continue it's normal operation without
entering the prompt when the user hits <enter>. That way one can avoid
the delay on UFS and HAMMER systems:

diff --git a/sys/boot/pc32/boot2/boot2.c b/sys/boot/pc32/boot2/boot2.c
index 459436f..55516be 100644
--- a/sys/boot/pc32/boot2/boot2.c
+++ b/sys/boot/pc32/boot2/boot2.c
@@ -346,7 +346,7 @@ main(void)
*/
if (autoboot && !*kname) {
memcpy(kname, PATH_BOOT3, sizeof(PATH_BOOT3));
- if (!keyhit(3*SECOND)) {
+ if (!keyhit(3*SECOND) || xgetc(0) == '\r') {
load();
memcpy(kname, PATH_BOOT3_ALT, sizeof(PATH_BOOT3_ALT));
load();

To actually enter the prompt one has to hit any other key (e.g. Esc).

The check for '\r' works ok for me, but maybe we also need to check
for '\n'?

Cheers,
Johannes

History

#1 Updated by tuxillo over 3 years ago

Johannes,

Is this still present? I see there was a commit related to this in
3735e368a1bdbe773c79c34512f49c905ff77bd7

Cheers,
Antonio Huete

#2 Updated by Johannes.Hofmann over 3 years ago

"Antonio Huete Jimenez \(via DragonFly issue tracker\)" <> wrote:
>
> Antonio Huete Jimenez <> added the comment:
>
> Johannes,
>
> Is this still present? I see there was a commit related to this in
> 3735e368a1bdbe773c79c34512f49c905ff77bd7

That commit changed things, so on installations with dedicated /boot
partition the speed up by hitting return works ok.
However it no longer works on installations that don't have a /boot
partition.
The patch I proposed in msg8262 makes it work on both kinds of
installations, but it's sort of a hack.

Cheers,
Johannes

Also available in: Atom PDF