Bug #1847

[patch] add Fred to dloader

Added by josepht over 4 years ago. Updated about 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

For your review:

http://leaf.dragonflybsd.org/~josepht/dloader.patch

This patch adds Fred to dloader. Please let me know your thoughts.
It looks roughly like this:

=========================== DragonFly BSD =========================
|
[logo] | 1. blah
| 2. blah
.
.
.
|
===================================================================

There's no limitation (other than sanity) on menu entries. However
the logo is currently arbitrarily limited to 17 lines. It would be
easy enough to allow for taller logos. The logo is currently 20
characters wide so care needs to be taken when making longish menu
entries.

Thanks,
Joe

History

#1 Updated by dillon about 4 years ago

:For your review:
:
:http://leaf.dragonflybsd.org/~josepht/dloader.patch
:
:This patch adds Fred to dloader. Please let me know your thoughts.
:It looks roughly like this:
:
:Thanks,
:Joe

I tried it out, very nice. I say commit the beast!

-Matt
Matthew Dillon
<>

#2 Updated by thomas.nikolajsen about 4 years ago

> This patch adds Fred to dloader. Please let me know your thoughts.

Yay Fred is back; also in technicolor!

It worksM; tried both i386 & x86_64.

Minor things:
- the header, 'DragonFly BSD', look better if centered between the two 'panes',
like in your mail (looks roughly like ..); the patch has header centered on full line.
- Fred on right (as old loader) looks a bit better (I guess it is easier to put him at left as in patch).

-thomas

#3 Updated by josepht about 4 years ago

On Thu, Sep 23, 2010 at 08:27:19AM +0000, Thomas Nikolajsen (via DragonFly issue tracker) wrote:
>
> Thomas Nikolajsen <> added the comment:
>
> > This patch adds Fred to dloader. Please let me know your thoughts.
>
> Yay Fred is back; also in technicolor!
>
> It worksM; tried both i386 & x86_64.
>
> Minor things:
> - the header, 'DragonFly BSD', look better if centered between the two 'panes',
> like in your mail (looks roughly like ..); the patch has header centered on full line.
> - Fred on right (as old loader) looks a bit better (I guess it is easier to put him at left as in patch).
>

I've centered the header as you mentioned and put Fred on the right
side by default. I added a new loader.conf variable; 'fred_on_left'
which anyone who would like Fred on the left can turn on.

The patch is still here:

http://leaf.dragonflybsd.org/~josepht/dloader.patch

Thank you for your feedback,
Joe

#4 Updated by eocallaghan about 4 years ago

Changing Status: Chatting->Testing.

#5 Updated by josepht1 about 4 years ago

committed: d0f33df3f1b97ff054ed3803b9afc1284699d003

Also available in: Atom PDF