Submit #2479

RealTek 8111F support

Added by y0n3t4n1 almost 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Hi.
Recently I've been playing with an AMD C-60 based mini-ITX system
and it needs a new ID for the on-board NIC added to re(4). The
latest DragonFly does not recognize the ID and instead shows the
following message to the console:
unknown hwrev 0x48000000, macmode 0x00000000

In the patch below, the addition to re_hwrevs[] is just a copy-and-paste
from the entry for RE_HWREV_8168F, so part of the flag may be wrong.

The description on the product is available at:
http://www.realtek.com.tw/products/productsView.aspx?Langid=1&PFid=5&Level=5&Conn=4&ProdID=291

Best Regards,
YONETANI Tomokazu.

commit b1f09266e49df9af9c64e5807438960df39d3031
Author: YONETANI Tomokazu <>
Date: Sat Dec 22 22:10:04 2012 +0900

RealTek8111F found in ASUS C60M1-I

diff --git a/sys/dev/netif/re/if_re.c b/sys/dev/netif/re/if_re.c
index a19a60b..150577a 100644
--- a/sys/dev/netif/re/if_re.c
+++ b/sys/dev/netif/re/if_re.c
@@ -253,6 +253,10 @@ static const struct re_hwrev re_hwrevs[] = {
RE_C_HWIM | RE_C_HWCSUM | RE_C_MAC2 | RE_C_PHYPMGT |
RE_C_AUTOPAD | RE_C_CONTIGRX | RE_C_STOP_RXTX },

+ { RE_HWREV_8111F, RE_MACVER_UNKN, RE_MTU_9K,
+ RE_C_HWIM | RE_C_HWCSUM | RE_C_MAC2 | RE_C_PHYPMGT |
+ RE_C_AUTOPAD | RE_C_CONTIGRX | RE_C_STOP_RXTX },
+
{ RE_HWREV_8100E, RE_MACVER_UNKN, ETHERMTU,
RE_C_HWCSUM | RE_C_FASTE },

@@ -1047,6 +1051,7 @@ re_probe(device_t dev)
sc->re_macver = RE_MACVER_2F;
break;
case RE_HWREV_8168F:
+ case RE_HWREV_8111F:
if (macmode == 0x000000)
sc->re_macver = RE_MACVER_30;
else if (macmode == 0x100000)
diff --git a/sys/dev/netif/re/if_rereg.h b/sys/dev/netif/re/if_rereg.h
index a962bf0..49097c2 100644
--- a/sys/dev/netif/re/if_rereg.h
+++ b/sys/dev/netif/re/if_rereg.h
@@ -167,6 +167,7 @@
#define RE_HWREV_8168C 0x3C000000
#define RE_HWREV_8168CP 0x3C800000
#define RE_HWREV_8105E 0x40800000
+#define RE_HWREV_8111F 0x48000000
#define RE_HWREV_8139CPLUS 0x74800000
#define RE_HWREV_8169SC2 0x98000000
#define RE_HWREV_8101E2 0xB4000000

History

#1 Updated by sepherosa almost 2 years ago

On Thu, Dec 27, 2012 at 5:23 PM, YONETANI Tomokazu via Redmine
<> wrote:
>
> Issue #2479 has been reported by YONETANI Tomokazu.
>
> ----------------------------------------
> Submit #2479: RealTek 8111F support
> http://bugs.dragonflybsd.org/issues/2479
>
> Author: YONETANI Tomokazu
> Status: New
> Priority: Normal
> Assignee:
> Category:
> Target version:
>
>
> Hi.
> Recently I've been playing with an AMD C-60 based mini-ITX system
> and it needs a new ID for the on-board NIC added to re(4). The
> latest DragonFly does not recognize the ID and instead shows the
> following message to the console:
> unknown hwrev 0x48000000, macmode 0x00000000
>
> In the patch below, the addition to re_hwrevs[] is just a copy-and-paste
> from the entry for RE_HWREV_8168F, so part of the flag may be wrong.

They probably are similar.

>
> The description on the product is available at:
> http://www.realtek.com.tw/products/productsView.aspx?Langid=1&amp;PFid=5&amp;Level=5&amp;Conn=4&amp;ProdID=291
>
> Best Regards,
> YONETANI Tomokazu.
>
> commit b1f09266e49df9af9c64e5807438960df39d3031
> Author: YONETANI Tomokazu <>
> Date: Sat Dec 22 22:10:04 2012 +0900
>
> RealTek8111F found in ASUS C60M1-I
>
> diff --git a/sys/dev/netif/re/if_re.c b/sys/dev/netif/re/if_re.c
> index a19a60b..150577a 100644
> --- a/sys/dev/netif/re/if_re.c
> +++ b/sys/dev/netif/re/if_re.c
> @@ -253,6 +253,10 @@ static const struct re_hwrev re_hwrevs[] = {
> RE_C_HWIM | RE_C_HWCSUM | RE_C_MAC2 | RE_C_PHYPMGT |
> RE_C_AUTOPAD | RE_C_CONTIGRX | RE_C_STOP_RXTX },
>
> + { RE_HWREV_8111F, RE_MACVER_UNKN, RE_MTU_9K,
> + RE_C_HWIM | RE_C_HWCSUM | RE_C_MAC2 | RE_C_PHYPMGT |
> + RE_C_AUTOPAD | RE_C_CONTIGRX | RE_C_STOP_RXTX },
> +
> { RE_HWREV_8100E, RE_MACVER_UNKN, ETHERMTU,
> RE_C_HWCSUM | RE_C_FASTE },
>
> @@ -1047,6 +1051,7 @@ re_probe(device_t dev)
> sc->re_macver = RE_MACVER_2F;
> break;
> case RE_HWREV_8168F:
> + case RE_HWREV_8111F:
> if (macmode == 0x000000)
> sc->re_macver = RE_MACVER_30;
> else if (macmode == 0x100000)
> diff --git a/sys/dev/netif/re/if_rereg.h b/sys/dev/netif/re/if_rereg.h
> index a962bf0..49097c2 100644
> --- a/sys/dev/netif/re/if_rereg.h
> +++ b/sys/dev/netif/re/if_rereg.h
> @@ -167,6 +167,7 @@
> #define RE_HWREV_8168C 0x3C000000
> #define RE_HWREV_8168CP 0x3C800000
> #define RE_HWREV_8105E 0x40800000
> +#define RE_HWREV_8111F 0x48000000
> #define RE_HWREV_8139CPLUS 0x74800000
> #define RE_HWREV_8169SC2 0x98000000
> #define RE_HWREV_8101E2 0xB4000000
>

This patch looks good, would you like to commit it yourself?

Best Regards,
sephe

--
Tomorrow Will Never Die

#2 Updated by y0n3t4n1 almost 2 years ago

  • Status changed from New to Closed

Committed as f922383e6babc4970b46e2de5c72716aa4afbeae .

Also available in: Atom PDF